Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add propType check with validation #2516

Merged
merged 2 commits into from
Jul 9, 2017
Merged

Add propType check with validation #2516

merged 2 commits into from
Jul 9, 2017

Conversation

timneutkens
Copy link
Member

@timneutkens timneutkens commented Jul 9, 2017 •
edited
Loading

Fixes #1275.

This is pretty amazing. It'll show a console.error when you use anything other than a defined prop in propTypes.

@timneutkens timneutkens requested a review from arunoda July 9, 2017 10:00
@arunoda arunoda merged commit ee29abb into vercel:v3-beta Jul 9, 2017
@arunoda arunoda removed their request for review July 9, 2017 13:12
@timneutkens timneutkens deleted the fix/add-proptype-check branch July 9, 2017 13:17
@jaydenseric jaydenseric mentioned this pull request Jul 17, 2017
Merged
@lock lock bot locked as resolved and limited conversation to collaborators Jul 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timneutkens @arunoda