Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(example/with-antd-mobile): Fix the example #25929

Closed

Conversation

akellbl4
Copy link

@akellbl4 akellbl4 commented Jun 9, 2021

Documentation / Examples

Fixed one of the items from #25854

  • Removes next/with-css
  • Excludes import CSS inside antd-mobile in any case (for frontend and backend)
  • Fixes regexp for null-loader
  • Import andt-mobile styles in _app.js
  • Move style from Head because it caused an error
  • Use Router.push instead of using withRouter HOC

  • Add the StackBlitz button in README.md
  • Make sure the linting passes

Live demo on StackBlitz

@ijjk ijjk added the examples Issue was opened via the examples template. label Jun 9, 2021
@d3lm
Copy link
Contributor

d3lm commented Jun 9, 2021

I think this is also missing some peer dependencies. Can you also fix those in this PR? Here's a link to the live preview from your fork. On local, if you install the deps with yarn you ll get the same error.

Update: I used the wrong branch. @akellbl4 posted the correct one below.

@d3lm
Copy link
Contributor

d3lm commented Jun 9, 2021

And once the error is fixed, can you also add the StackBlitz button to the README.md? Here's the snippet:

## Preview

Preview the example live on [StackBlitz](http://stackblitz.com/):

[![Open in StackBlitz](https://developer.stackblitz.com/img/open_in_stackblitz.svg)](https://stackblitz.com/github/vercel/next.js/tree/canary/examples/with-ant-design-mobile)

@akellbl4 akellbl4 force-pushed the fix-examples-with-ant-design-mobile branch from 2c7c4cf to fc879b5 Compare June 9, 2021 11:51
@akellbl4
Copy link
Author

akellbl4 commented Jun 9, 2021

@d3lm as I can see you created a live example that uses a different branch.
Here is the right live example

@d3lm
Copy link
Contributor

d3lm commented Jun 9, 2021

Oh, my bad! Sorry about that. Thanks for linking the correct one!

@d3lm d3lm mentioned this pull request Jun 9, 2021
20 tasks
@akellbl4 akellbl4 force-pushed the fix-examples-with-ant-design-mobile branch 2 times, most recently from 6a6ac07 to f94c310 Compare June 14, 2021 19:11
@ijjk ijjk added create-next-app Related to our CLI tool for quickly starting a new Next.js application. type: documentation type: next labels Jun 14, 2021
Pavel Mineev added 3 commits June 14, 2021 22:14
- remove next/with-css
- exclude import css inside antd-mobile in any case
- fix regexp for null-loader
- import andt-mobile styles in _app.js
- move style from Head because it caused an error
@akellbl4 akellbl4 force-pushed the fix-examples-with-ant-design-mobile branch from f94c310 to 0035b9b Compare June 14, 2021 19:14
@akellbl4
Copy link
Author

akellbl4 commented Jun 14, 2021

This example has been removed by Tim in this PR. I've restored it because it had been updated :)

@akellbl4 akellbl4 force-pushed the fix-examples-with-ant-design-mobile branch from 0035b9b to db3e6ee Compare June 14, 2021 19:37
@balazsorban44
Copy link
Member

Hi, this PR seems to be a bit out-of-date with our example guidelines, so I am going to close it. If you have the intention to bring it up-to-date, please do! Thanks for the work either way! 🙏 💚

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
create-next-app Related to our CLI tool for quickly starting a new Next.js application. examples Issue was opened via the examples template. type: next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants