-
Notifications
You must be signed in to change notification settings - Fork 27.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(example/with-antd-mobile): Fix the example #25929
(example/with-antd-mobile): Fix the example #25929
Conversation
I think this is also missing some peer dependencies. Can you also fix those in this PR? Here's a link to the live preview from your fork. On local, if you install the deps with Update: I used the wrong branch. @akellbl4 posted the correct one below. |
And once the error is fixed, can you also add the StackBlitz button to the ## Preview
Preview the example live on [StackBlitz](http://stackblitz.com/):
[![Open in StackBlitz](https://developer.stackblitz.com/img/open_in_stackblitz.svg)](https://stackblitz.com/github/vercel/next.js/tree/canary/examples/with-ant-design-mobile) |
2c7c4cf
to
fc879b5
Compare
@d3lm as I can see you created a live example that uses a different branch. |
Oh, my bad! Sorry about that. Thanks for linking the correct one! |
6a6ac07
to
f94c310
Compare
- remove next/with-css - exclude import css inside antd-mobile in any case - fix regexp for null-loader - import andt-mobile styles in _app.js - move style from Head because it caused an error
f94c310
to
0035b9b
Compare
This example has been removed by Tim in this PR. I've restored it because it had been updated :) |
0035b9b
to
db3e6ee
Compare
Hi, this PR seems to be a bit out-of-date with our example guidelines, so I am going to close it. If you have the intention to bring it up-to-date, please do! Thanks for the work either way! 🙏 💚 |
Documentation / Examples
Fixed one of the items from #25854
next/with-css
antd-mobile
in any case (for frontend and backend)null-loader
andt-mobile
styles in_app.js
Head
because it caused an errorRouter.push
instead of usingwithRouter
HOCLive demo on StackBlitz