Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unsupported examples #26075

Merged
merged 5 commits into from
Jun 14, 2021
Merged

Remove unsupported examples #26075

merged 5 commits into from
Jun 14, 2021

Conversation

timneutkens
Copy link
Member

  • Removes examples that use deprecated @zeit/next-css
  • Updates cases where zeit was still used

Bug

  • Related issues linked using fixes #number
  • Integration tests added

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.

Documentation / Examples

  • Make sure the linting passes

@ijjk ijjk added create-next-app Related to our CLI tool for quickly starting a new Next.js application. type: documentation examples Issue/PR related to examples type: next labels Jun 14, 2021
@ijjk
Copy link
Member

ijjk commented Jun 14, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/remove-unsupported-examples Change
buildDuration 14.1s 14s -72ms
buildDurationCached 3.3s 3.3s -44ms
nodeModulesSize 46.5 MB 46.5 MB ⚠️ +3 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary timneutkens/next.js fix/remove-unsupported-examples Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.698 2.724 ⚠️ +0.03
/ avg req/sec 926.48 917.83 ⚠️ -8.65
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.682 1.681 0
/error-in-render avg req/sec 1485.96 1487.58 +1.62
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/remove-unsupported-examples Change
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 20.2 kB 20.2 kB ✓
webpack-HASH.js gzip 804 B 804 B ✓
Overall change 60.3 kB 60.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/remove-unsupported-examples Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/remove-unsupported-examples Change
_app-HASH.js gzip 801 B 801 B ✓
_error-HASH.js gzip 3.18 kB 3.18 kB ✓
amp-HASH.js gzip 527 B 527 B ✓
css-HASH.js gzip 334 B 334 B ✓
hooks-HASH.js gzip 890 B 890 B ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 1.64 kB 1.64 kB ✓
routerDirect..HASH.js gzip 333 B 333 B ✓
withRouter-HASH.js gzip 330 B 330 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 8.43 kB 8.43 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/remove-unsupported-examples Change
_buildManifest.js gzip 395 B 395 B ✓
Overall change 395 B 395 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/remove-unsupported-examples Change
index.html gzip 522 B 522 B ✓
link.html gzip 535 B 535 B ✓
withRouter.html gzip 516 B 516 B ✓
Overall change 1.57 kB 1.57 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/remove-unsupported-examples Change
buildDuration 15.7s 15.8s ⚠️ +137ms
buildDurationCached 4.3s 4.4s ⚠️ +111ms
nodeModulesSize 46.5 MB 46.5 MB ⚠️ +3 B
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/remove-unsupported-examples Change
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 20.2 kB 20.2 kB ✓
webpack-HASH.js gzip 804 B 804 B ✓
Overall change 60.3 kB 60.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/remove-unsupported-examples Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/remove-unsupported-examples Change
_app-HASH.js gzip 801 B 801 B ✓
_error-HASH.js gzip 3.18 kB 3.18 kB ✓
amp-HASH.js gzip 527 B 527 B ✓
css-HASH.js gzip 334 B 334 B ✓
hooks-HASH.js gzip 890 B 890 B ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 1.64 kB 1.64 kB ✓
routerDirect..HASH.js gzip 333 B 333 B ✓
withRouter-HASH.js gzip 330 B 330 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 8.43 kB 8.43 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/remove-unsupported-examples Change
_buildManifest.js gzip 395 B 395 B ✓
Overall change 395 B 395 B ✓
Serverless bundles
vercel/next.js canary timneutkens/next.js fix/remove-unsupported-examples Change
_error.js 16.9 kB 16.9 kB ✓
404.html 1.98 kB 1.98 kB ✓
500.html 1.96 kB 1.96 kB ✓
amp.amp.html 10.8 kB 10.8 kB ✓
amp.html 1.17 kB 1.17 kB ✓
css.html 1.35 kB 1.35 kB ✓
hooks.html 1.23 kB 1.23 kB ✓
index.js 17.2 kB 17.2 kB ✓
link.js 17.4 kB 17.4 kB -2 B
routerDirect.js 17.4 kB 17.4 kB ⚠️ +2 B
withRouter.js 17.4 kB 17.4 kB ✓
Overall change 105 kB 105 kB ✓
Webpack 4 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/remove-unsupported-examples Change
buildDuration 12.2s 12.2s -20ms
buildDurationCached 5.1s 4.8s -258ms
nodeModulesSize 46.5 MB 46.5 MB ⚠️ +3 B
Page Load Tests Overall increase ✓
vercel/next.js canary timneutkens/next.js fix/remove-unsupported-examples Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.752 2.663 -0.09
/ avg req/sec 908.43 938.75 +30.32
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.633 1.605 -0.03
/error-in-render avg req/sec 1530.5 1558.12 +27.62
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/remove-unsupported-examples Change
677f882d2ed8..HASH.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.99 kB 7.99 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 61.1 kB 61.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/remove-unsupported-examples Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/remove-unsupported-examples Change
_app-HASH.js gzip 1.07 kB 1.07 kB ✓
_error-HASH.js gzip 3.85 kB 3.85 kB ✓
amp-HASH.js gzip 536 B 536 B ✓
css-HASH.js gzip 339 B 339 B ✓
hooks-HASH.js gzip 887 B 887 B ✓
index-HASH.js gzip 227 B 227 B ✓
link-HASH.js gzip 1.63 kB 1.63 kB ✓
routerDirect..HASH.js gzip 303 B 303 B ✓
withRouter-HASH.js gzip 302 B 302 B ✓
e025d2764813..52f.css gzip 125 B 125 B ✓
Overall change 9.28 kB 9.28 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/remove-unsupported-examples Change
_buildManifest.js gzip 420 B 420 B ✓
Overall change 420 B 420 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/remove-unsupported-examples Change
index.html gzip 568 B 568 B ✓
link.html gzip 582 B 582 B ✓
withRouter.html gzip 561 B 561 B ✓
Overall change 1.71 kB 1.71 kB ✓
Commit: 79040ac

@ijjk
Copy link
Member

ijjk commented Jun 14, 2021

Failing test suites

Commit: 79040ac

test/integration/basic/test/index.test.js

  • Basic Features > should polyfill Node.js modules
Expand output

● Basic Features › should polyfill Node.js modules

thrown: "Exceeded timeout of 300000 ms for a test.
Use jest.setTimeout(newTimeout) to increase the timeout value, if this is a long-running test."

  35 |   afterAll(() => killApp(context.server))
  36 |
> 37 |   it('should polyfill Node.js modules', async () => {
     |   ^
  38 |     const browser = await webdriver(context.appPort, '/node-browser-polyfills')
  39 |
  40 |     console.error({

  at integration/basic/test/index.test.js:37:3
  at Object.<anonymous> (integration/basic/test/index.test.js:18:1)

@timneutkens timneutkens merged commit de08b1f into vercel:canary Jun 14, 2021
@timneutkens timneutkens deleted the fix/remove-unsupported-examples branch June 14, 2021 18:27
akellbl4 pushed a commit to akellbl4/next.js that referenced this pull request Jun 14, 2021
@timneutkens @ijjk
Remove unsupported examples (vercel#26075)
9c72a79 
Co-authored-by: JJ Kasper <jj@jjsweb.site>
@akellbl4 akellbl4 mentioned this pull request Jun 14, 2021
Closed
2 tasks
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Jun 16, 2021
@timneutkens @ijjk
Remove unsupported examples (vercel#26075)
c635b03 
Co-authored-by: JJ Kasper <jj@jjsweb.site>
@lostfictions lostfictions mentioned this pull request Jul 26, 2021
Open
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@divmain divmain Awaiting requested review from divmain

@leerob leerob Awaiting requested review from leerob

@lfades lfades Awaiting requested review from lfades

@shuding shuding Awaiting requested review from shuding

Assignees
No one assigned
Labels
create-next-app Related to our CLI tool for quickly starting a new Next.js application. examples Issue/PR related to examples type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timneutkens @ijjk