Clean up examples package.json
#27121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucleray
requested review from
huozhi,
ijjk,
leerob,
lfades,
padmaia,
shuding,
styfle and
timneutkens
as code owners
styfle
previously approved these changes
Jul 12, 2021
ijjk
previously approved these changes
Jul 12, 2021
leerob
reviewed
Jul 12, 2021
leerob
previously approved these changes
Jul 12, 2021
ijjk
approved these changes
Jul 12, 2021
styfle
approved these changes
Jul 12, 2021
oBusk
added a commit
to oBusk/next.js
that referenced
this pull request
Aug 14, 2021
This was mentioned in vercel#27121 but it looks like it didn't end up being in the merge?
oBusk
added a commit
to oBusk/next.js
that referenced
this pull request
Aug 14, 2021
ijjk
added a commit
that referenced
this pull request
Aug 14, 2021
* Add licences to all example/package.json that lack them * Revert "Add licences to all example/package.json that lack them" This reverts commit 5d4e250. * Update check-examples to remove `license` field from examples * Remove `license` from all examples. This was mentioned in #27121 but it looks like it didn't end up being in the merge? Co-authored-by: JJ Kasper <jj@jjsweb.site>
ijjk
pushed a commit
that referenced
this pull request
Aug 14, 2021
* Add ci script to check examples * Install moreutils for `sponge` command. It's not very pretty, but I'm not sure how to replace sponge in a good way in the shell script * Prettier names in the workflow * Move "check-examples" into build_test_deploy workflow * Start breaking the jq script into multiple lines * Add checks for cleanups in #27121 * Run the `check-examples.sh` script to cleanup all remaining examples.
flybayer
pushed a commit
to blitz-js/next.js
that referenced
this pull request
Aug 19, 2021
Clean up package.json files in the `examples` directory: - Add `private: true` - Remove `version` (because they are irrelevant for packages that are not meant to be published) - Remove `name` (because they are optional for packages that are not meant to be published, and when someone clones an example, they often rename it and the property becomes stale) - Remove `author` - Remove `description` - Remove `license` Also remove `with-dynamic-app-layout` example completely, since it does the same as `layout-component` (vercel#27121 (comment)). ## Documentation / Examples - [x] Make sure the linting passes
oBusk
added a commit
to oBusk/next.js
that referenced
this pull request
Oct 26, 2021
To be consistent with vercel#27121.
oBusk
added a commit
to oBusk/next.js
that referenced
this pull request
Oct 26, 2021
To be consistent with vercel#27121.
10 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up package.json files in the
examplesdirectory:private: trueversion(because they are irrelevant for packages that are not meant to be published)name(because they are optional for packages that are not meant to be published, and when someone clones an example, they often rename it and the property becomes stale)authordescriptionlicenseAlso remove
with-dynamic-app-layoutexample completely, since it does the same aslayout-component(#27121 (comment)).Documentation / Examples