-
Notifications
You must be signed in to change notification settings - Fork 27.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add node trace source map handling in dev mode #2816
Conversation
This will literally save hours of dev time, as it is currently so non-obvious what line is causing an error. 👍 👍 |
This looks really good, let me give it a few spins before merging 👌 |
This is brilliant @kpdecker ! |
server/index.js
Outdated
@@ -29,6 +29,14 @@ const blockedPages = { | |||
|
|||
export default class Server { | |||
constructor ({ dir = '.', dev = false, staticMarkup = false, quiet = false, conf = null } = {}) { | |||
// When in dev mode, remap the inline source maps that we genenrate within the webpack portion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small typo: genenrate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
This looks like something really great. |
Tried it last night, works 👌 |
This is fantastic. |
I just published 3.2.0 which has this PR. |
This broke browser source maps.
|
I can't really make sense of that output. What command is it from? What does your nextconfig look like? |
And what browser? |
I'm thinking this is most likely related to the absolute imports example 🤔 cc @sergiodxa |
I just tried a random example -- with-redux, same result. |
I'm also experiencing the same issue as @dnakov , I reverted back to next@3.1.0 and no longer see an issue with sourcemaps while debugging. |
Fixed in #2900. |
Fixes #2285