Defer routeChangeComplete until head was updated #4919
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HaNdTriX
force-pushed
the
route-change-complete
branch
3 times, most recently
from
0af70f2
to
332761a
Compare
|
I wonder if the tests still pass with the suspense support update of next/head |
HaNdTriX
force-pushed
the
route-change-complete
branch
2 times, most recently
from
ab89a5f
to
529d386
Compare
|
I removed the fix, but the tests are not passing. |
|
What i meant to say is that the head update doesn’t get triggered until componentDidMount |
|
I am closing this, since it is out of date. We should tackle this later. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem are we trying to solve?
Currently the
routeChangeCompleteevent fires before the head was updated.Solution
Defer the
routeChangeCompleteevent until the head update is done.Closes: #4044, #4889
Related: #574, #4838