Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: removes npx info & moves src link up #4972

Merged
merged 4 commits into from
Aug 19, 2018

Conversation

rouzbeh84
Copy link
Contributor

FIXES: #4970

confirmed rest of instructions work so left them in, even though duplicate of guide over at Material UI. thoughts?

@@ -41,5 +32,3 @@ now
## The idea behind the example

This example features how you use [material-ui](https://github.com/mui-org/material-ui) (Material components that implement Google's Material Design) with Next.js.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets only leave this link, so that they can update the instructions there whenever needed and we won't have this issue coming back 👍

@@ -1,34 +1,4 @@
[![Deploy to now](https://deploy.now.sh/static/button.svg)](https://deploy.now.sh/?repo=https://github.com/mui-org/material-ui/tree/master/examples/nextjs)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also remove the deploy to now button 👍

Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you very much 🙏

@timneutkens timneutkens merged commit 639df91 into vercel:canary Aug 19, 2018
@timneutkens
Copy link
Member

Great first contribution 👍 🙏

@lock lock bot locked as resolved and limited conversation to collaborators Aug 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create-next-app doesn't work on with-material-ui
2 participants