Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint examples #4985

Merged
merged 10 commits into from
Aug 20, 2018
Merged

Lint examples #4985

merged 10 commits into from
Aug 20, 2018

Conversation

HaNdTriX
Copy link
Contributor

@HaNdTriX HaNdTriX commented Aug 19, 2018

Somehow all "**/examples/**/lib/**", files got ignored by standard.js.

https://github.com/zeit/next.js/blob/canary/package.json#L49

This PR fixes all the corresponding lint issues and removes the problematic line from the linter config.

Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@timneutkens timneutkens merged commit 5ff7c07 into vercel:canary Aug 20, 2018
@timneutkens
Copy link
Member

@HaNdTriX sent you a DM on spectrum.chat

@popuguytheparrot
Copy link
Contributor

what a C++ style ?

@HaNdTriX HaNdTriX deleted the lint-examples branch August 27, 2018 08:11
@lock lock bot locked as resolved and limited conversation to collaborators Aug 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants