Update with react 18next to latest #5017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this should also finally close: #4532 |
timneutkens
reviewed
Aug 23, 2018
| @@ -16,7 +16,7 @@ yarn create next-app --example with-react-i18next with-react-i18next-app | |||
|
|
|||
| ### Download manually | |||
|
|
|||
| Download the example: | |||
| Download the example [or clone the repo](https://github.com/zeit/next.js): | |||
There was a problem hiding this comment.
We shouldn't recommend cloning the repo. You're pulling in all of the Next.js source + you have to build it etc.
timneutkens
approved these changes
Aug 24, 2018
|
Awesome, thanks! |
|
thank you for all the work done here... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4532
This updates the with-react-i18next example to latest next.js version with support for the _app.js file.