Moved nanoid use from next-server to next/build #5441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slaskis
commented
Oct 12, 2018
| const distDir = join(dir, config.distDir) | ||
|
|
||
| let buildId = await config.generateBuildId() // defaults to a uuid | ||
| if (buildId == null) { |
There was a problem hiding this comment.
== is intentional here to catch null or undefined (either would mess up any potential string methods)
or would you prefer to make this more explicit like typeof buildId == "string"?
timneutkens
requested changes
Nov 2, 2018
|
I don't think so. The reason for #5427 was to move nanoid to server but this PR just leaves it where it was. |
|
Ah I see 👍 |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another (more proper?) solution to #5427
Is this what you had in mind @timneutkens ?