Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add with style-sheet example #5572

Merged
merged 5 commits into from
Nov 1, 2018
Merged

Add with style-sheet example #5572

merged 5 commits into from
Nov 1, 2018

Conversation

giuseppeg
Copy link
Contributor

This is an example integration of my latest CSS in JS library. It features extraction to css file :)

client/index.js Outdated
@@ -83,7 +82,7 @@ export default async ({
Component = await pageLoader.loadPage(page)

if (typeof Component !== 'function') {
throw new Error(`The default export is not a React Component in page: "${pathname}"`)
throw new Error(`The default export is not a React Component in page: "${page}"`)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure why these changes are showing up in this diff

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh canary vs master

@timneutkens timneutkens merged commit c95abc2 into vercel:canary Nov 1, 2018
@giuseppeg giuseppeg deleted the add-stylesheet-example branch November 1, 2018 13:59
@lock lock bot locked as resolved and limited conversation to collaborators Nov 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants