-
Notifications
You must be signed in to change notification settings - Fork 27.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update React from 2983249dd to 7508dcd5c #58216
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnoff
requested review from
a team,
timneutkens,
ijjk,
shuding,
huozhi,
feedthejim,
ztanner and
wyattjoh
as code owners
November 8, 2023 19:04
sebmarkbage
approved these changes
Nov 8, 2023
ijjk
approved these changes
Nov 8, 2023
Stats from current PRDefault Build (Increase detected
|
vercel/next.js canary | gnoff/next.js update-react | Change | |
---|---|---|---|
buildDuration | 10.4s | 10.5s | N/A |
buildDurationCached | 5.9s | 6.6s | |
nodeModulesSize | 175 MB | 199 MB | |
nextStartRea..uration (ms) | 400ms | 400ms | ✓ |
Client Bundles (main, webpack)
vercel/next.js canary | gnoff/next.js update-react | Change | |
---|---|---|---|
199-HASH.js gzip | 29.2 kB | 29.1 kB | N/A |
3f784ff6-HASH.js gzip | 53.2 kB | 53.3 kB | N/A |
494.HASH.js gzip | 180 B | 181 B | N/A |
framework-HASH.js gzip | 45.2 kB | 45.2 kB | ✓ |
main-app-HASH.js gzip | 241 B | 239 B | N/A |
main-HASH.js gzip | 31.7 kB | 31.8 kB | N/A |
webpack-HASH.js gzip | 1.7 kB | 1.7 kB | ✓ |
Overall change | 46.9 kB | 46.9 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | gnoff/next.js update-react | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | gnoff/next.js update-react | Change | |
---|---|---|---|
_app-HASH.js gzip | 194 B | 195 B | N/A |
_error-HASH.js gzip | 182 B | 181 B | N/A |
amp-HASH.js gzip | 504 B | 506 B | N/A |
css-HASH.js gzip | 322 B | 323 B | N/A |
dynamic-HASH.js gzip | 2.5 kB | 2.5 kB | ✓ |
edge-ssr-HASH.js gzip | 253 B | 255 B | N/A |
head-HASH.js gzip | 348 B | 347 B | N/A |
hooks-HASH.js gzip | 369 B | 368 B | N/A |
image-HASH.js gzip | 4.3 kB | 4.3 kB | N/A |
index-HASH.js gzip | 256 B | 256 B | ✓ |
link-HASH.js gzip | 2.65 kB | 2.65 kB | N/A |
routerDirect..HASH.js gzip | 311 B | 311 B | ✓ |
script-HASH.js gzip | 384 B | 383 B | N/A |
withRouter-HASH.js gzip | 307 B | 308 B | N/A |
1afbb74e6ecf..834.css gzip | 106 B | 106 B | ✓ |
Overall change | 3.17 kB | 3.17 kB | ✓ |
Client Build Manifests
vercel/next.js canary | gnoff/next.js update-react | Change | |
---|---|---|---|
_buildManifest.js gzip | 483 B | 484 B | N/A |
Overall change | 0 B | 0 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | gnoff/next.js update-react | Change | |
---|---|---|---|
index.html gzip | 528 B | 528 B | ✓ |
link.html gzip | 541 B | 541 B | ✓ |
withRouter.html gzip | 524 B | 522 B | N/A |
Overall change | 1.07 kB | 1.07 kB | ✓ |
Edge SSR bundle Size
vercel/next.js canary | gnoff/next.js update-react | Change | |
---|---|---|---|
edge-ssr.js gzip | 92.5 kB | 92.5 kB | N/A |
page.js gzip | 145 kB | 145 kB | N/A |
Overall change | 0 B | 0 B | ✓ |
Middleware size
vercel/next.js canary | gnoff/next.js update-react | Change | |
---|---|---|---|
middleware-b..fest.js gzip | 623 B | 626 B | N/A |
middleware-r..fest.js gzip | 150 B | 151 B | N/A |
middleware.js gzip | 24.8 kB | 24.8 kB | N/A |
edge-runtime..pack.js gzip | 1.92 kB | 1.92 kB | ✓ |
Overall change | 1.92 kB | 1.92 kB | ✓ |
Next Runtimes Overall increase ⚠️
vercel/next.js canary | gnoff/next.js update-react | Change | |
---|---|---|---|
app-page-exp...dev.js gzip | 166 kB | 167 kB | |
app-page-exp..prod.js gzip | 93.4 kB | 93.1 kB | N/A |
app-page-tur..prod.js gzip | 94.1 kB | 93.8 kB | N/A |
app-page-tur..prod.js gzip | 88.8 kB | 88.5 kB | N/A |
app-page.run...dev.js gzip | 136 kB | 137 kB | |
app-page.run..prod.js gzip | 88.1 kB | 87.8 kB | N/A |
app-route-ex...dev.js gzip | 23.5 kB | 23.7 kB | |
app-route-ex..prod.js gzip | 16.4 kB | 16.3 kB | N/A |
app-route-tu..prod.js gzip | 16.4 kB | 16.3 kB | N/A |
app-route-tu..prod.js gzip | 16 kB | 15.9 kB | N/A |
app-route.ru...dev.js gzip | 22.9 kB | 23.1 kB | |
app-route.ru..prod.js gzip | 16 kB | 15.9 kB | N/A |
pages-api-tu..prod.js gzip | 9.37 kB | 9.37 kB | ✓ |
pages-api.ru...dev.js gzip | 9.64 kB | 9.64 kB | ✓ |
pages-api.ru..prod.js gzip | 9.37 kB | 9.37 kB | ✓ |
pages-turbo...prod.js gzip | 21.8 kB | 21.8 kB | ✓ |
pages.runtim...dev.js gzip | 22.5 kB | 22.5 kB | ✓ |
pages.runtim..prod.js gzip | 21.8 kB | 21.8 kB | ✓ |
server.runti..prod.js gzip | 48.8 kB | 48.8 kB | ✓ |
Overall change | 492 kB | 494 kB |
Diff details
Diff for page.js
Diff too large to display
Diff for 199-HASH.js
Diff too large to display
Diff for 3f784ff6-HASH.js
Diff too large to display
Diff for app-page-exp..ntime.dev.js
failed to diff
Diff for app-page-exp..time.prod.js
Diff too large to display
Diff for app-page-tur..time.prod.js
Diff too large to display
Diff for app-page-tur..time.prod.js
Diff too large to display
Diff for app-page.runtime.dev.js
failed to diff
Diff for app-page.runtime.prod.js
Diff too large to display
Diff for app-route-ex..ntime.dev.js
Diff too large to display
Diff for app-route-ex..time.prod.js
Diff too large to display
Diff for app-route-tu..time.prod.js
Diff too large to display
Diff for app-route-tu..time.prod.js
Diff too large to display
Diff for app-route.runtime.dev.js
Diff too large to display
Diff for app-route.ru..time.prod.js
Diff too large to display
Tests Passed |
ijjk
approved these changes
Nov 8, 2023
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated React from 2983249dd to 7508dcd5c.