Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update turbopack #63541

Merged
merged 14 commits into from
Mar 25, 2024
Merged

Update turbopack #63541

merged 14 commits into from
Mar 25, 2024

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Mar 21, 2024 •
edited
Loading

@kdy1 kdy1 self-assigned this Mar 21, 2024
@kdy1 kdy1 requested review from timneutkens, ijjk, shuding, huozhi and a team as code owners March 21, 2024 02:07
@ijjk ijjk added the created-by: Turbopack team PRs by the Turbopack team. label Mar 21, 2024
@kdy1 kdy1 mentioned this pull request Mar 21, 2024
Merged
@ijjk
Copy link
Member

ijjk commented Mar 21, 2024 •
edited
Loading

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js kdy1/swc-core-0-90-8 Change
buildDuration 13.7s 13.7s N/A
buildDurationCached 7.5s 6.1s N/A
nodeModulesSize 198 MB 198 MB ✓
nextStartRea..uration (ms) 436ms 437ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js kdy1/swc-core-0-90-8 Change
2453-HASH.js gzip 30.8 kB 30.8 kB N/A
3304.HASH.js gzip 181 B 181 B ✓
3f784ff6-HASH.js gzip 53.7 kB 53.7 kB ✓
8299-HASH.js gzip 5.04 kB 5.04 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB ✓
main-app-HASH.js gzip 242 B 242 B ✓
main-HASH.js gzip 32.2 kB 32.2 kB N/A
webpack-HASH.js gzip 1.68 kB 1.68 kB N/A
Overall change 99.3 kB 99.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js kdy1/swc-core-0-90-8 Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary vercel/next.js kdy1/swc-core-0-90-8 Change
_app-HASH.js gzip 196 B 197 B N/A
_error-HASH.js gzip 184 B 184 B ✓
amp-HASH.js gzip 505 B 505 B ✓
css-HASH.js gzip 324 B 325 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 258 B 258 B ✓
head-HASH.js gzip 352 B 352 B ✓
hooks-HASH.js gzip 370 B 371 B N/A
image-HASH.js gzip 4.21 kB 4.21 kB ✓
index-HASH.js gzip 259 B 259 B ✓
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 314 B 312 B N/A
script-HASH.js gzip 386 B 386 B ✓
withRouter-HASH.js gzip 309 B 309 B ✓
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 6.57 kB 6.57 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js kdy1/swc-core-0-90-8 Change
_buildManifest.js gzip 481 B 484 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js kdy1/swc-core-0-90-8 Change
index.html gzip 530 B 528 B N/A
link.html gzip 541 B 541 B ✓
withRouter.html gzip 525 B 523 B N/A
Overall change 541 B 541 B ✓
Edge SSR bundle Size
vercel/next.js canary vercel/next.js kdy1/swc-core-0-90-8 Change
edge-ssr.js gzip 95.3 kB 95.3 kB N/A
page.js gzip 3.04 kB 3.04 kB N/A
Overall change 0 B 0 B ✓
Middleware size
vercel/next.js canary vercel/next.js kdy1/swc-core-0-90-8 Change
middleware-b..fest.js gzip 624 B 625 B N/A
middleware-r..fest.js gzip 151 B 151 B ✓
middleware.js gzip 25.5 kB 25.5 kB N/A
edge-runtime..pack.js gzip 839 B 839 B ✓
Overall change 990 B 990 B ✓
Next Runtimes
vercel/next.js canary vercel/next.js kdy1/swc-core-0-90-8 Change
app-page-exp...dev.js gzip 170 kB 170 kB ✓
app-page-exp..prod.js gzip 96.8 kB 96.8 kB ✓
app-page-tur..prod.js gzip 98.5 kB 98.5 kB ✓
app-page-tur..prod.js gzip 92.8 kB 92.8 kB ✓
app-page.run...dev.js gzip 144 kB 144 kB ✓
app-page.run..prod.js gzip 91.3 kB 91.3 kB ✓
app-route-ex...dev.js gzip 21.4 kB 21.4 kB ✓
app-route-ex..prod.js gzip 15.1 kB 15.1 kB ✓
app-route-tu..prod.js gzip 15.1 kB 15.1 kB ✓
app-route-tu..prod.js gzip 14.8 kB 14.8 kB ✓
app-route.ru...dev.js gzip 21 kB 21 kB ✓
app-route.ru..prod.js gzip 14.8 kB 14.8 kB ✓
pages-api-tu..prod.js gzip 9.55 kB 9.55 kB ✓
pages-api.ru...dev.js gzip 9.82 kB 9.82 kB ✓
pages-api.ru..prod.js gzip 9.55 kB 9.55 kB ✓
pages-turbo...prod.js gzip 22.5 kB 22.5 kB ✓
pages.runtim...dev.js gzip 23.1 kB 23.1 kB ✓
pages.runtim..prod.js gzip 22.4 kB 22.4 kB ✓
server.runti..prod.js gzip 50.9 kB 50.9 kB ✓
Overall change 943 kB 943 kB ✓
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js kdy1/swc-core-0-90-8 Change
0.pack gzip 1.57 MB 1.57 MB ⚠️ +2.75 kB
index.pack gzip 106 kB 106 kB N/A
Overall change 1.57 MB 1.57 MB ⚠️ +2.75 kB
Diff details
Diff for middleware.js

Diff too large to display

Commit: f3d6af2

@ijjk
Copy link
Member

ijjk commented Mar 21, 2024 •
edited
Loading

Failing test suites

Commit: b23b3e7

pnpm test-start test/e2e/app-dir/app-client-cache/client-cache.test.ts

  • app dir client cache semantics > prefetch={true} > should prefetch again after 5 mins if the link is visible again
Expand output

● app dir client cache semantics › prefetch={true} › should prefetch again after 5 mins if the link is visible again

TIMED OUT: success

fail

undefined

  636 |
  637 |   if (hardError) {
> 638 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content + '\n\n' + lastErr)
      |           ^
  639 |   }
  640 |   return false
  641 | }

  at check (lib/next-test-utils.ts:638:11)
  at Object.<anonymous> (e2e/app-dir/app-client-cache/client-cache.test.ts:176:11)

Read more about building and testing Next.js in contributing.md.

pnpm test-dev test/development/acceptance-app/ReactRefreshLogBox.test.ts

  • ReactRefreshLogBox app default > unterminated JSX
Expand output

● ReactRefreshLogBox app default › unterminated JSX

expect(received).toMatchInlineSnapshot(snapshot)

Snapshot name: `ReactRefreshLogBox app default unterminated JSX 1`

- Snapshot  - 2
+ Received  + 2

@@ -1,18 +1,18 @@
  ./index.js
  Error: 
    x Unexpected token. Did you mean `{'}'}` or `&rbrace;`?
-    ,-[4:1]
+    ,-[TEST_DIR/index.js:4:1]
   4 |       <p>lol</p>
   5 |     div
   6 |   )
   7 | }
     : ^
     `----

    x Unexpected eof
-    ,-[4:1]
+    ,-[TEST_DIR/index.js:4:1]
   4 |       <p>lol</p>
   5 |     div
   6 |   )
   7 | }
     `----

  237 |       `)
  238 |     } else {
> 239 |       expect(source).toMatchInlineSnapshot(`
      |                      ^
  240 |         "./index.js
  241 |         Error: 
  242 |           x Unexpected token. Did you mean \`{'}'}\` or \`&rbrace;\`?

  at Object.toMatchInlineSnapshot (development/acceptance-app/ReactRefreshLogBox.test.ts:239:22)

Read more about building and testing Next.js in contributing.md.

@kdy1 kdy1 enabled auto-merge (squash) March 22, 2024 02:51
@kdy1 kdy1 disabled auto-merge March 22, 2024 03:24
kdy1 added a commit to vercel/turborepo that referenced this pull request Mar 22, 2024
@kdy1
Update swc_core to v0.90.24 (#7796)
4774f9e 
### Description

Update SWC crates to
swc-project/swc@ad932f0,
to keep in sync.


 - Closes PACK-2807
 - Closes PACK-2819

### Testing Instructions

See next.js counterpart: vercel/next.js#63541
@kdy1 kdy1 requested review from a team, feedthejim, ztanner and wyattjoh as code owners March 22, 2024 13:03
@kdy1 kdy1 enabled auto-merge (squash) March 25, 2024 00:36
@kdy1 kdy1 disabled auto-merge March 25, 2024 01:37
@kdy1 kdy1 changed the title Update swc_core to v0.90.24 Update turbopack Mar 25, 2024
@kdy1 kdy1 enabled auto-merge (squash) March 25, 2024 01:37
@kdy1 kdy1 merged commit 6b65905 into canary Mar 25, 2024
75 of 78 checks passed
@kdy1 kdy1 deleted the kdy1/swc-core-0-90-8 branch March 25, 2024 03:15
This was referenced Mar 25, 2024
Closed
Merged
@github-actions github-actions bot added the locked label Apr 8, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@timneutkens timneutkens timneutkens approved these changes

@shuding shuding Awaiting requested review from shuding

@huozhi huozhi Awaiting requested review from huozhi

@feedthejim feedthejim Awaiting requested review from feedthejim

@ztanner ztanner Awaiting requested review from ztanner

@wyattjoh wyattjoh Awaiting requested review from wyattjoh

Assignees

@kdy1 kdy1

Labels
created-by: Turbopack team PRs by the Turbopack team. locked type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kdy1 @ijjk @timneutkens