Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix webpack loader incorrectly calling custom_evaluate #7813

Merged
merged 1 commit into from
Mar 22, 2024
Merged

fix webpack loader incorrectly calling custom_evaluate #7813

merged 1 commit into from
Mar 22, 2024

Conversation

sokra
Copy link
Member

@sokra sokra commented Mar 22, 2024 •
edited
Loading

Description

fixes SCSS HMR for imported files

Testing Instructions

Closes PACK-2818

fixes PACK-2809

@sokra sokra requested a review from a team as a code owner March 22, 2024 10:27
@vercel Vercel
Copy link

vercel bot commented Mar 22, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview Mar 22, 2024 10:36am
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2024 10:36am
8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Mar 22, 2024 10:36am
examples-designsystem-docs ⬜️ Ignored (Inspect) Mar 22, 2024 10:36am
examples-gatsby-web ⬜️ Ignored (Inspect) Mar 22, 2024 10:36am
examples-kitchensink-blog ⬜️ Ignored (Inspect) Mar 22, 2024 10:36am
examples-native-web ⬜️ Ignored (Inspect) Mar 22, 2024 10:36am
examples-svelte-web ⬜️ Ignored (Inspect) Mar 22, 2024 10:36am
examples-tailwind-web ⬜️ Ignored (Inspect) Mar 22, 2024 10:36am
examples-vite-web ⬜️ Ignored (Inspect) Mar 22, 2024 10:36am

@github-actions GitHub Actions
Copy link
Contributor

🟢 Turbopack Benchmark CI successful 🟢

Thanks

@github-actions GitHub Actions
Copy link
Contributor

✅ This change can build next-swc

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 22, 2024 •
edited
Loading

🟢 CI successful 🟢

Thanks

@sokra sokra merged commit 2cc8af0 into main Mar 22, 2024
50 checks passed
@sokra sokra deleted the sokra/fix-webpack-loader-dependencies branch March 22, 2024 13:32
@timneutkens timneutkens mentioned this pull request Mar 23, 2024
Closed
1 task
@kdy1 kdy1 mentioned this pull request Mar 25, 2024
Merged
kdy1 added a commit to vercel/next.js that referenced this pull request Mar 25, 2024
@kdy1 @timneutkens
Update turbopack (#63541)
6b65905 
# Turbopack

* vercel/turborepo#7815 <!-- Tobias Koppers - fix
alias in getResolve -->
* vercel/turborepo#7796 <!-- Donny/강동윤 - Update
`swc_core` to `v0.90.24` -->
* vercel/turborepo#7775 <!-- Tobias Koppers - fix
single css chunks with import context -->
* vercel/turborepo#7776 <!-- Tobias Koppers - change
port of trace-server -->
* vercel/turborepo#7763 <!-- Tobias Koppers -
Tracing improvements -->
* vercel/turborepo#7813 <!-- Tobias Koppers - fix
webpack loader incorrectly calling custom_evaluate -->
* vercel/turborepo#7764 <!-- Tobias Koppers - fix
some small bugs in turbo-tasks that are required for GC -->
* vercel/turborepo#7816 <!-- Chris Olszewski -
chore: remove some unused imports -->
* vercel/turborepo#7823 <!-- OJ Kwon -
fix(sourcemap): update sourcemap, remove checker -->

### What?

Update SWC crates to
swc-project/swc@ad932f0

### Why?

To keep in sync.

### How?



 - Closes PACK-2807
 - Closes PACK-2819

---------

Co-authored-by: Tim Neutkens <tim@timneutkens.nl>
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
@sokra
fix webpack loader incorrectly calling custom_evaluate (vercel/turbor…
719ae82 
…epo#7813)

### Description

fixes SCSS HMR for imported files

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->


Closes PACK-2818

fixes PACK-2809
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@sokra
fix webpack loader incorrectly calling custom_evaluate (vercel/turbor…
7fd1044 
…epo#7813)

### Description

fixes SCSS HMR for imported files

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->


Closes PACK-2818

fixes PACK-2809
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@sokra
fix webpack loader incorrectly calling custom_evaluate (vercel/turbor…
d7c70eb 
…epo#7813)

### Description

fixes SCSS HMR for imported files

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->


Closes PACK-2818

fixes PACK-2809
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
@sokra
fix webpack loader incorrectly calling custom_evaluate (vercel/turbor…
639e6c6 
…epo#7813)

### Description

fixes SCSS HMR for imported files

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->


Closes PACK-2818

fixes PACK-2809
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timneutkens timneutkens timneutkens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sokra @timneutkens