Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(dev-overlay): refine the error message header styling #63823

Merged
merged 14 commits into from
Apr 5, 2024

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Mar 28, 2024

What

Polish the UX based on the feedbacks from @sambecker

  • Fix the font that still use mono
  • Align the color, to use red for the warnings
  • Give the title to build error
  • Only highlight the nextjs doc url as link

After vs Before

Runtime Error

image image

Build Error

image image

Closes NEXT-2958

@ijjk
Copy link
Member

ijjk commented Mar 28, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js fix/dev-overlay-styling Change
buildDuration 14s 14s N/A
buildDurationCached 7.4s 6.2s N/A
nodeModulesSize 199 MB 199 MB ⚠️ +6.45 kB
nextStartRea..uration (ms) 407ms 398ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js fix/dev-overlay-styling Change
2453-HASH.js gzip 31.4 kB 31.4 kB N/A
3304.HASH.js gzip 181 B 181 B
3f784ff6-HASH.js gzip 53.7 kB 53.7 kB
8299-HASH.js gzip 5.04 kB 5.04 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 242 B 241 B N/A
main-HASH.js gzip 32.2 kB 32.2 kB N/A
webpack-HASH.js gzip 1.68 kB 1.68 kB N/A
Overall change 99 kB 99 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js fix/dev-overlay-styling Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js fix/dev-overlay-styling Change
_app-HASH.js gzip 196 B 197 B N/A
_error-HASH.js gzip 184 B 184 B
amp-HASH.js gzip 505 B 505 B
css-HASH.js gzip 324 B 325 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 258 B 258 B
head-HASH.js gzip 352 B 352 B
hooks-HASH.js gzip 370 B 371 B N/A
image-HASH.js gzip 4.21 kB 4.21 kB
index-HASH.js gzip 259 B 259 B
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 314 B 312 B N/A
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 309 B 309 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 6.57 kB 6.57 kB
Client Build Manifests
vercel/next.js canary vercel/next.js fix/dev-overlay-styling Change
_buildManifest.js gzip 481 B 484 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js fix/dev-overlay-styling Change
index.html gzip 529 B 528 B N/A
link.html gzip 541 B 541 B
withRouter.html gzip 524 B 523 B N/A
Overall change 541 B 541 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js fix/dev-overlay-styling Change
edge-ssr.js gzip 95.4 kB 95.4 kB N/A
page.js gzip 3.06 kB 3.06 kB
Overall change 3.06 kB 3.06 kB
Middleware size
vercel/next.js canary vercel/next.js fix/dev-overlay-styling Change
middleware-b..fest.js gzip 626 B 625 B N/A
middleware-r..fest.js gzip 151 B 151 B
middleware.js gzip 25.5 kB 25.5 kB N/A
edge-runtime..pack.js gzip 839 B 839 B
Overall change 990 B 990 B
Next Runtimes
vercel/next.js canary vercel/next.js fix/dev-overlay-styling Change
app-page-exp...dev.js gzip 170 kB 170 kB
app-page-exp..prod.js gzip 97 kB 97 kB
app-page-tur..prod.js gzip 98.8 kB 98.8 kB
app-page-tur..prod.js gzip 93 kB 93 kB
app-page.run...dev.js gzip 144 kB 144 kB
app-page.run..prod.js gzip 91.5 kB 91.5 kB
app-route-ex...dev.js gzip 21.4 kB 21.4 kB
app-route-ex..prod.js gzip 15.1 kB 15.1 kB
app-route-tu..prod.js gzip 15.1 kB 15.1 kB
app-route-tu..prod.js gzip 14.9 kB 14.9 kB
app-route.ru...dev.js gzip 21.1 kB 21.1 kB
app-route.ru..prod.js gzip 14.9 kB 14.9 kB
pages-api-tu..prod.js gzip 9.55 kB 9.55 kB
pages-api.ru...dev.js gzip 9.82 kB 9.82 kB
pages-api.ru..prod.js gzip 9.55 kB 9.55 kB
pages-turbo...prod.js gzip 22.5 kB 22.5 kB
pages.runtim...dev.js gzip 23.1 kB 23.1 kB
pages.runtim..prod.js gzip 22.4 kB 22.4 kB
server.runti..prod.js gzip 51.1 kB 51.1 kB
Overall change 945 kB 945 kB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js fix/dev-overlay-styling Change
0.pack gzip 1.58 MB 1.58 MB N/A
index.pack gzip 106 kB 106 kB ⚠️ +141 B
Overall change 106 kB 106 kB ⚠️ +141 B
Diff details
Diff for middleware.js

Diff too large to display

Commit: cda2222

@huozhi huozhi marked this pull request as draft March 28, 2024 15:37
@huozhi huozhi force-pushed the fix/dev-overlay-styling branch from 16e9384 to be11dd0 Compare April 5, 2024 09:52
@ijjk
Copy link
Member

ijjk commented Apr 5, 2024

Failing test suites

Commit: cda2222

TURBOPACK=1 pnpm test test/integration/eslint/test/next-lint.test.js (turbopack)

  • Next Lint > First Time Setup > installs eslint and eslint-config-next as devDependencies if missing with yarn
  • Next Lint > First Time Setup > creates .eslintrc.json file with a default configuration
  • Next Lint > First Time Setup > shows a successful message when completed
Expand output

● Next Lint › First Time Setup › installs eslint and eslint-config-next as devDependencies if missing with yarn

ENOENT: no such file or directory, open '/tmp/icv5i3ljm1r/package.json'

● Next Lint › First Time Setup › creates .eslintrc.json file with a default configuration

ENOENT: no such file or directory, open '/tmp/jy94cv6fm7/package.json'

● Next Lint › First Time Setup › shows a successful message when completed

ENOENT: no such file or directory, open '/tmp/xjb3dxxvbsp/package.json'

Read more about building and testing Next.js in contributing.md.

@huozhi huozhi changed the title fix(dev-overlay): revert font and link text change style(dev-overlay): refine the error message header styling Apr 5, 2024
@huozhi huozhi marked this pull request as ready for review April 5, 2024 12:23
@huozhi huozhi enabled auto-merge (squash) April 5, 2024 21:23
@huozhi huozhi disabled auto-merge April 5, 2024 21:39
@huozhi huozhi enabled auto-merge (squash) April 5, 2024 21:39
@huozhi huozhi disabled auto-merge April 5, 2024 21:39
@huozhi huozhi merged commit 14c8900 into canary Apr 5, 2024
72 of 79 checks passed
@huozhi huozhi deleted the fix/dev-overlay-styling branch April 5, 2024 21:39
huozhi added a commit that referenced this pull request Apr 5, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants