Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test reverting "style(dev-overlay): refine the error message header styling" #64135

Closed
wants to merge 1 commit into from

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Apr 5, 2024

Reverts #63823

Closes NEXT-3023

Copy link

linear bot commented Apr 5, 2024

@ijjk
Copy link
Member

ijjk commented Apr 5, 2024

Failing test suites

Commit: 0da05f0

TURBOPACK=1 pnpm test test/integration/eslint/test/next-lint.test.js (turbopack)

  • Next Lint > First Time Setup > installs eslint and eslint-config-next as devDependencies if missing with yarn
  • Next Lint > First Time Setup > creates .eslintrc.json file with a default configuration
  • Next Lint > First Time Setup > shows a successful message when completed
Expand output

● Next Lint › First Time Setup › installs eslint and eslint-config-next as devDependencies if missing with yarn

ENOENT: no such file or directory, open '/tmp/91xnlya2eyf/package.json'

● Next Lint › First Time Setup › creates .eslintrc.json file with a default configuration

ENOENT: no such file or directory, open '/tmp/3chyhg8ujje/package.json'

● Next Lint › First Time Setup › shows a successful message when completed

ENOENT: no such file or directory, open '/tmp/62dm4u5g8t8/package.json'

Read more about building and testing Next.js in contributing.md.

pnpm test test/integration/cli/test/index.test.js

  • CLI Usage > dev > NODE_OPTIONS='--inspect'
Expand output

● CLI Usage › dev › NODE_OPTIONS='--inspect'

TIMED OUT: /Debugger listening on/

Starting inspector on 127.0.0.1:9229 failed: address already in use
Starting inspector on 127.0.0.1:9230 failed: address already in use


undefined

  642 |
  643 |   if (hardError) {
> 644 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content + '\n\n' + lastErr)
      |           ^
  645 |   }
  646 |   return false
  647 | }

  at check (lib/next-test-utils.ts:644:11)
  at Object.<anonymous> (integration/cli/test/index.test.js:552:9)

Read more about building and testing Next.js in contributing.md.

pnpm test test/integration/custom-server/test/index.test.js

  • Custom Server using HTTPS > compression handling > should handle compression for route /
  • Custom Server using HTTPS > compression handling > should handle compression for route /no-query
  • Custom Server using HTTPS > with dynamic assetPrefix > should render nested index
  • Custom Server using HTTPS > with dynamic assetPrefix > should handle custom urls with requests handler
Expand output

● Custom Server using HTTPS › with dynamic assetPrefix › should render nested index

expect(received).toMatch(expected)

Expected pattern: /made it to dashboard/
Received string:  "
              <pre>missing required error components, refreshing...</pre>
              <script>
                async function check() {
                  const res = await fetch(location.href).catch(() => ({}))·
                  if (res.status === 200) {
                    location.reload()
                  } else {
                    setTimeout(check, 1000)
                  }
                }
                check()
              </script>"

  119 |         agent,
  120 |       })
> 121 |       expect(html).toMatch(/made it to dashboard/)
      |                    ^
  122 |     })
  123 |
  124 |     it('should handle custom urls with requests handler', async () => {

  at Object.toMatch (integration/custom-server/test/index.test.js:121:20)

● Custom Server using HTTPS › with dynamic assetPrefix › should handle custom urls with requests handler

expect(received).toMatch(expected)

Expected pattern: /made it to dashboard/
Received string:  "
              <pre>missing required error components, refreshing...</pre>
              <script>
                async function check() {
                  const res = await fetch(location.href).catch(() => ({}))·
                  if (res.status === 200) {
                    location.reload()
                  } else {
                    setTimeout(check, 1000)
                  }
                }
                check()
              </script>"

  131 |         }
  132 |       )
> 133 |       expect(html).toMatch(/made it to dashboard/)
      |                    ^
  134 |     })
  135 |
  136 |     it.skip('should contain customServer in NEXT_DATA', async () => {

  at Object.toMatch (integration/custom-server/test/index.test.js:133:20)

● Custom Server using HTTPS › compression handling › should handle compression for route /

thrown: "Exceeded timeout of 60000 ms for a hook.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  257 |
  258 |   describe('compression handling', function () {
> 259 |     beforeAll(() => startServer())
      |     ^
  260 |     afterAll(() => killApp(server))
  261 |
  262 |     it.each(['/', '/no-query'])(

  at beforeAll (integration/custom-server/test/index.test.js:259:5)
  at describe (integration/custom-server/test/index.test.js:258:3)
      at Array.forEach (<anonymous>)
  at Object.<anonymous> (integration/custom-server/test/index.test.js:29:2)

● Custom Server using HTTPS › compression handling › should handle compression for route /no-query

thrown: "Exceeded timeout of 60000 ms for a hook.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  257 |
  258 |   describe('compression handling', function () {
> 259 |     beforeAll(() => startServer())
      |     ^
  260 |     afterAll(() => killApp(server))
  261 |
  262 |     it.each(['/', '/no-query'])(

  at beforeAll (integration/custom-server/test/index.test.js:259:5)
  at describe (integration/custom-server/test/index.test.js:258:3)
      at Array.forEach (<anonymous>)
  at Object.<anonymous> (integration/custom-server/test/index.test.js:29:2)

Read more about building and testing Next.js in contributing.md.

@ijjk
Copy link
Member

ijjk commented Apr 5, 2024

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js revert-63823-fix/dev-overlay-styling Change
buildDuration 14s 14s N/A
buildDurationCached 7.6s 6.5s N/A
nodeModulesSize 199 MB 199 MB N/A
nextStartRea..uration (ms) 398ms 379ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js revert-63823-fix/dev-overlay-styling Change
2453-HASH.js gzip 31.4 kB 31.4 kB N/A
3304.HASH.js gzip 181 B 181 B
3f784ff6-HASH.js gzip 53.7 kB 53.7 kB
8299-HASH.js gzip 5.04 kB 5.04 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 242 B 242 B
main-HASH.js gzip 32.2 kB 32.2 kB N/A
webpack-HASH.js gzip 1.68 kB 1.68 kB N/A
Overall change 99.3 kB 99.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js revert-63823-fix/dev-overlay-styling Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js revert-63823-fix/dev-overlay-styling Change
_app-HASH.js gzip 196 B 197 B N/A
_error-HASH.js gzip 184 B 184 B
amp-HASH.js gzip 505 B 505 B
css-HASH.js gzip 324 B 325 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 258 B 258 B
head-HASH.js gzip 352 B 352 B
hooks-HASH.js gzip 370 B 371 B N/A
image-HASH.js gzip 4.21 kB 4.21 kB
index-HASH.js gzip 259 B 259 B
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 314 B 312 B N/A
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 309 B 309 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 6.57 kB 6.57 kB
Client Build Manifests
vercel/next.js canary vercel/next.js revert-63823-fix/dev-overlay-styling Change
_buildManifest.js gzip 481 B 484 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js revert-63823-fix/dev-overlay-styling Change
index.html gzip 529 B 529 B
link.html gzip 541 B 541 B
withRouter.html gzip 523 B 524 B N/A
Overall change 1.07 kB 1.07 kB
Edge SSR bundle Size
vercel/next.js canary vercel/next.js revert-63823-fix/dev-overlay-styling Change
edge-ssr.js gzip 95.4 kB 95.4 kB N/A
page.js gzip 3.06 kB 3.06 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js revert-63823-fix/dev-overlay-styling Change
middleware-b..fest.js gzip 624 B 624 B
middleware-r..fest.js gzip 151 B 151 B
middleware.js gzip 25.5 kB 25.5 kB N/A
edge-runtime..pack.js gzip 839 B 839 B
Overall change 1.61 kB 1.61 kB
Next Runtimes
vercel/next.js canary vercel/next.js revert-63823-fix/dev-overlay-styling Change
app-page-exp...dev.js gzip 170 kB 170 kB
app-page-exp..prod.js gzip 97 kB 97 kB
app-page-tur..prod.js gzip 98.8 kB 98.8 kB
app-page-tur..prod.js gzip 93 kB 93 kB
app-page.run...dev.js gzip 144 kB 144 kB
app-page.run..prod.js gzip 91.5 kB 91.5 kB
app-route-ex...dev.js gzip 21.4 kB 21.4 kB
app-route-ex..prod.js gzip 15.1 kB 15.1 kB
app-route-tu..prod.js gzip 15.1 kB 15.1 kB
app-route-tu..prod.js gzip 14.9 kB 14.9 kB
app-route.ru...dev.js gzip 21.1 kB 21.1 kB
app-route.ru..prod.js gzip 14.9 kB 14.9 kB
pages-api-tu..prod.js gzip 9.55 kB 9.55 kB
pages-api.ru...dev.js gzip 9.82 kB 9.82 kB
pages-api.ru..prod.js gzip 9.55 kB 9.55 kB
pages-turbo...prod.js gzip 22.5 kB 22.5 kB
pages.runtim...dev.js gzip 23.1 kB 23.1 kB
pages.runtim..prod.js gzip 22.4 kB 22.4 kB
server.runti..prod.js gzip 51.1 kB 51.1 kB
Overall change 945 kB 945 kB
build cache
vercel/next.js canary vercel/next.js revert-63823-fix/dev-overlay-styling Change
0.pack gzip 1.58 MB 1.58 MB N/A
index.pack gzip 106 kB 106 kB N/A
Overall change 0 B 0 B
Diff details
Diff for middleware.js

Diff too large to display

Commit: 0da05f0

@huozhi huozhi closed this Apr 5, 2024
@huozhi huozhi deleted the revert-63823-fix/dev-overlay-styling branch April 5, 2024 23:49
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants