Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated the example of with-xstate to utilize the App Router #69960

Merged
merged 5 commits into from
Sep 11, 2024

Conversation

Sam-Phillemon9493
Copy link
Contributor

This PR updates the with-xstate example to use the App Router. Here are the changes that have been made:

  • Renamed the pages folder to the app folder.
  • Updated the routing for / files to align with the App Router.
  • moved the components and machine folder inside the app directory by renaming it to _components and _machine
  • Added the layout.tsx file as part of the App Router.
  • Updated the package.json file.

CC: @samcx

@ijjk ijjk added the examples Issue was opened via the examples template. label Sep 11, 2024
@ijjk
Copy link
Member

ijjk commented Sep 11, 2024

Allow CI Workflow Run

  • approve CI run for commit: 9210e87

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@Sam-Phillemon9493 Sam-Phillemon9493 marked this pull request as ready for review September 11, 2024 09:53
Copy link

socket-security bot commented Sep 11, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@xstate/react@4.1.2 None 0 36.1 kB xstate-release-bot
npm/xstate@5.18.1 None 0 1.66 MB xstate-release-bot

🚮 Removed packages: npm/@xstate/react@3.2.2, npm/xstate@4.38.3

View full report↗︎

@samcx samcx self-requested a review September 11, 2024 20:45
@samcx
Copy link
Member

samcx commented Sep 11, 2024

@Sam-Phillemon9493 Thank you for submitting a PR!

For next time—

  1. Add a reviewer instead of just pinging me in the description (I have manually add myself every time).
  2. Make sure to run the script pnpm check-examples, to have the latest next-env.d.ts
  3. Make note the small changes I made in the package.json

@samcx samcx merged commit 5348db4 into vercel:canary Sep 11, 2024
38 checks passed
@Sam-Phillemon9493
Copy link
Contributor Author

@Sam-Phillemon9493 Thank you for submitting a PR!

For next time—

  1. Add a reviewer instead of just pinging me in the description (I have manually add myself every time).
  2. Make sure to run the script pnpm check-examples, to have the latest next-env.d.ts
  3. Make note the small changes I made in the package.json

@samcx Noted—thanks for the feedback!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue was opened via the examples template. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants