Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update with web worker example to utilize the App Router #70058

Merged
merged 5 commits into from
Sep 13, 2024

Conversation

Sam-Phillemon9493
Copy link
Contributor

@Sam-Phillemon9493 Sam-Phillemon9493 commented Sep 13, 2024

This PR updates the with-web-worker example to use the App Router. Here are the changes that have been made:

  • Renamed the pages folder to the app folder.
  • Updated the routing for / files to align with the App Router.
  • Added the layout.tsx file as part of the App Router.
  • Updated the package.json file.

The following actions were performed as part of this PR:

  • Ran pnpm prettier-check with no issues found.
  • Executed the pnpm check-examples script.

@ijjk ijjk added the examples Issue was opened via the examples template. label Sep 13, 2024
@ijjk
Copy link
Member

ijjk commented Sep 13, 2024

Allow CI Workflow Run

  • approve CI run for commit: 0c0e41c

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@Sam-Phillemon9493 Sam-Phillemon9493 marked this pull request as ready for review September 13, 2024 07:08
@Sam-Phillemon9493
Copy link
Contributor Author

This PR updates the with-web-worker example to use the App Router. Here are the changes that have been made:

  • Renamed the pages folder to the app folder.
  • Updated the routing for / files to align with the App Router.
  • Added the layout.tsx file as part of the App Router.
  • Updated the package.json file.

The following actions were performed as part of this PR:

  • Ran pnpm prettier-check with no issues found.
  • Executed the pnpm check-examples script.

@samcx I recall you mentioned in my previous PR that I should add you as a reviewer directly instead of tagging you in the description. However, I don’t have the necessary permissions to do so. Could you assist with adjusting the access rights or advise me on how to add reviewers?

@samcx
Copy link
Member

samcx commented Sep 13, 2024

However, I don’t have the necessary permissions to do so. Could you assist with adjusting the access rights or advise me on how to add reviewers?

Oh interesting, I didn't know that was the case. In that case, feel free to CC me instead.

@samcx
Copy link
Member

samcx commented Sep 13, 2024

@Sam-Phillemon9493 Thank you for submitting a PR!

Only thing I changed to be up-to-date is the tsconfig.json file (copied from create-next-app@canary).

@samcx samcx merged commit e99f736 into vercel:canary Sep 13, 2024
38 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue was opened via the examples template. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants