Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the example of with-styled-jsx-plugins to utilize the App Router #70663

Merged

Conversation

PapatMayuri
Copy link
Contributor

This PR updates the with-styled-jsx-plugins example for using the App Router.
Here are the changes that have been made:

  • I renamed the "pages" folder and moved it to the "app" folder.
  • Added the layout.TSX file as part of the App Router.
  • Updated the package.json file.

CC: @samcx

@ijjk ijjk added the examples Issue was opened via the examples template. label Oct 1, 2024
@ijjk
Copy link
Member

ijjk commented Oct 1, 2024

Allow CI Workflow Run

  • approve CI run for commit: 6752783

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@PapatMayuri PapatMayuri marked this pull request as ready for review October 2, 2024 19:12
@samcx
Copy link
Member

samcx commented Oct 2, 2024

@PapatMayuri

For the future, please double check these examples are working when testing (test next dev, next build, and deploying).

Let's go ahead and remove these Babel style-jsx-... examples. It's getting an error, and it's likely not worth the effort to fix/keep around as an example.

@PapatMayuri
Copy link
Contributor Author

Okay Sure @samcx will update

Copy link

@vignesh1507 vignesh1507 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM...i agree with the changes.

@samcx
Copy link
Member

samcx commented Oct 17, 2024

@PapatMayuri Let me know if you're able to update this!

@PapatMayuri
Copy link
Contributor Author

@samcx PR is Updated please check.

Copy link
Member

@samcx samcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting a PR!

:lgtm:

@samcx samcx enabled auto-merge (squash) November 26, 2024 22:17
@samcx samcx merged commit 9cbc4d8 into vercel:canary Nov 26, 2024
39 checks passed
wyattjoh pushed a commit that referenced this pull request Nov 28, 2024
…ter (#70663)

This PR updates the with-styled-jsx-plugins example for using the App
Router.
Here are the changes that have been made:

- I renamed the "pages" folder and moved it to the "app" folder.
- Added the layout.TSX file as part of the App Router.
- Updated the package.json file.

CC: @samcx

---------

Co-authored-by: qed42 <qed42@Janhvis-Macbook-Pro.local>
Co-authored-by: Sam Ko <sam@vercel.com>
samcx added a commit that referenced this pull request Dec 10, 2024
## Description
Follow up [the
comment](#70663 (comment))
in #70663.

> Let's go ahead and remove these Babel `style-jsx-...` examples. It's
getting an error, and it's likely not worth the effort to fix/keep
around as an example.

In addition,
[with-styled-components-babel](https://github.com/vercel/next.js/tree/canary/examples/with-styled-components-babel)
example is no longer needed because the simple [with-styled-components
example](https://github.com/vercel/next.js/tree/canary/examples/with-styled-components)
exists.

CC: @samcx 

### Adding or Updating Examples

- [x] The "examples guidelines" are followed from our contributing doc
https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md
- [x] Make sure the linting passes by running `pnpm build && pnpm lint`.
See
https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md

Co-authored-by: Sam Ko <sam@vercel.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue was opened via the examples template. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants