Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: remove with-styled-components-babel #73229

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Conversation

JamBalaya56562
Copy link
Contributor

@JamBalaya56562 JamBalaya56562 commented Nov 27, 2024

Description

Follow up the comment in #70663.

Let's go ahead and remove these Babel style-jsx-... examples. It's getting an error, and it's likely not worth the effort to fix/keep around as an example.

In addition, with-styled-components-babel example is no longer needed because the simple with-styled-components example exists.

CC: @samcx

Adding or Updating Examples

@ijjk ijjk added the examples Issue was opened via the examples template. label Nov 27, 2024
@ijjk
Copy link
Member

ijjk commented Nov 27, 2024

Allow CI Workflow Run

  • approve CI run for commit: 8d305bc

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@JamBalaya56562 JamBalaya56562 force-pushed the babel branch 4 times, most recently from fd9018b to 50b942e Compare December 9, 2024 01:35
@samcx samcx enabled auto-merge (squash) December 10, 2024 06:22
Copy link
Member

@samcx samcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting a PR!

:lgtm:

@samcx samcx merged commit 467226c into vercel:canary Dec 10, 2024
39 checks passed
@JamBalaya56562 JamBalaya56562 deleted the babel branch December 10, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples Issue was opened via the examples template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants