Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(turbopack): Use ResolvedVc<T> for struct fields in turbopack-ecmascript #73302

Merged
merged 9 commits into from
Nov 29, 2024
Merged

refactor(turbopack): Use ResolvedVc<T> for struct fields in turbopack-ecmascript #73302

merged 9 commits into from
Nov 29, 2024
+24 −17

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Nov 28, 2024 •
edited by padmaia
Loading

Closes PACK-3582

@ijjk ijjk added the created-by: Turbopack team PRs by the Turbopack team. label Nov 28, 2024
This was referenced Nov 28, 2024
Merged
Closed
@kdy1 Graphite App
Copy link
Member Author

kdy1 commented Nov 28, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Nov 28, 2024
Merged
Merged
@kdy1 kdy1 force-pushed the kdy1/resolved-vc-turbopack-core branch from c82527a to 66ade37 Compare November 28, 2024 06:07
@kdy1 kdy1 force-pushed the kdy1/resolved-vc-turbopack-ecmascript branch 2 times, most recently from 089d4ff to 6c2777e Compare November 28, 2024 06:31
@kdy1 kdy1 changed the base branch from kdy1/resolved-vc-turbopack-core to kdy1/resolved-vc-next-api November 28, 2024 06:31
@kdy1 kdy1 force-pushed the kdy1/resolved-vc-next-api branch from 660c994 to d66adaa Compare November 28, 2024 07:10
@kdy1 kdy1 force-pushed the kdy1/resolved-vc-turbopack-ecmascript branch 2 times, most recently from df3c600 to a307f96 Compare November 28, 2024 07:18
@ijjk ijjk added the Turbopack Related to Turbopack with Next.js. label Nov 28, 2024
@kdy1 kdy1 changed the base branch from kdy1/resolved-vc-next-api to kdy1/resolved-vc-next-core November 28, 2024 07:18
@kdy1 kdy1 mentioned this pull request Nov 28, 2024
Merged
@kdy1 kdy1 force-pushed the kdy1/resolved-vc-next-core branch from 6e550eb to 929ef30 Compare November 28, 2024 07:27
@kdy1 kdy1 force-pushed the kdy1/resolved-vc-turbopack-ecmascript branch 2 times, most recently from cbf5304 to 412cc57 Compare November 28, 2024 08:44
@kdy1 kdy1 force-pushed the kdy1/resolved-vc-next-core branch from eb3f787 to 298897a Compare November 28, 2024 09:04
@kdy1 kdy1 force-pushed the kdy1/resolved-vc-turbopack-ecmascript branch from 412cc57 to 5959f01 Compare November 28, 2024 09:04
@kdy1 kdy1 force-pushed the kdy1/resolved-vc-next-core branch 2 times, most recently from dab1d26 to 777c2a0 Compare November 28, 2024 10:38
@kdy1 kdy1 force-pushed the kdy1/resolved-vc-turbopack-ecmascript branch from 83aa4c5 to d438784 Compare November 28, 2024 10:39
@kdy1 kdy1 force-pushed the kdy1/resolved-vc-next-core branch from 777c2a0 to 611e43e Compare November 29, 2024 17:20
@kdy1 kdy1 force-pushed the kdy1/resolved-vc-turbopack-ecmascript branch 2 times, most recently from ffb497b to 7554a5f Compare November 29, 2024 17:22
@kdy1 kdy1 changed the title turbopack-ecmascript: ResolvedVc<T> refactor(turbopack): Use ResolvedVc<T> for struct fields in turbopack-ecmascript Nov 29, 2024
@kdy1 kdy1 marked this pull request as ready for review November 29, 2024 17:41
@kdy1 kdy1 requested a review from bgw November 29, 2024 17:41
@kdy1 kdy1 force-pushed the kdy1/resolved-vc-next-core branch from 3729ef6 to 2138fe1 Compare November 29, 2024 20:16
@kdy1 kdy1 force-pushed the kdy1/resolved-vc-turbopack-ecmascript branch 2 times, most recently from 28eee92 to 6be6e77 Compare November 29, 2024 20:48
@kdy1 kdy1 changed the base branch from kdy1/resolved-vc-next-core to graphite-base/73302 November 29, 2024 22:51
@kdy1 kdy1 force-pushed the graphite-base/73302 branch from d221f24 to bc06c4c Compare November 29, 2024 22:51
@kdy1 kdy1 force-pushed the kdy1/resolved-vc-turbopack-ecmascript branch from 6be6e77 to cc26c4e Compare November 29, 2024 22:51
@kdy1 kdy1 changed the base branch from graphite-base/73302 to canary November 29, 2024 22:52
@kdy1 kdy1 force-pushed the kdy1/resolved-vc-turbopack-ecmascript branch from cc26c4e to 9ae0845 Compare November 29, 2024 22:52
@ijjk
Copy link
Member

ijjk commented Nov 29, 2024 •
edited
Loading

Tests Passed

This was referenced Nov 29, 2024
Merged
Merged
@kdy1 kdy1 merged commit e06bb4b into canary Nov 29, 2024
107 of 112 checks passed
@kdy1 Graphite App
Copy link
Member Author

kdy1 commented Nov 29, 2024

Merge activity

  • Nov 30, 8:51 AM GMT+9: A user merged this pull request with Graphite.

@kdy1 kdy1 deleted the kdy1/resolved-vc-turbopack-ecmascript branch November 29, 2024 23:51
This was referenced Nov 30, 2024
Merged
Merged
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mischnic mischnic mischnic approved these changes

@bgw bgw Awaiting requested review from bgw

Assignees
No one assigned
Labels
created-by: Turbopack team PRs by the Turbopack team. locked Turbopack Related to Turbopack with Next.js.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kdy1 @ijjk @mischnic