Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(turbopack): Use ResolvedVc<T> for struct fields in next-api, final part #73367

Merged
merged 12 commits into from
Dec 8, 2024
Merged

refactor(turbopack): Use ResolvedVc<T> for struct fields in next-api, final part #73367

merged 12 commits into from
Dec 8, 2024

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Nov 29, 2024 •
edited by padmaia
Loading

Closes PACK-3622

@ijjk ijjk added created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js. labels Nov 29, 2024
This was referenced Nov 29, 2024
Merged
Merged
Merged
Merged
@kdy1 Graphite App
Copy link
Member Author

kdy1 commented Nov 29, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@kdy1 kdy1 mentioned this pull request Nov 29, 2024
Merged
@kdy1 kdy1 changed the title fix build refactor(turbopack): Use ResolvedVc<T> for struct fields in next-api, final part Nov 29, 2024
@kdy1 kdy1 force-pushed the kdy1/resolved-vc-turbopack-core branch from 8f8fcbe to cde5aa6 Compare November 29, 2024 23:53
@kdy1 kdy1 force-pushed the _kdy1/resolved-vc-next-api-last branch from 30c18ae to e4482ba Compare November 29, 2024 23:53
@kdy1 kdy1 force-pushed the kdy1/resolved-vc-turbopack-core branch from cde5aa6 to 8e62f48 Compare November 29, 2024 23:59
@kdy1 kdy1 force-pushed the _kdy1/resolved-vc-next-api-last branch 3 times, most recently from 81a09af to 2a196b0 Compare November 30, 2024 01:35
This was referenced Nov 30, 2024
Merged
Merged
@kdy1 kdy1 force-pushed the _kdy1/resolved-vc-next-api-last branch from 2a196b0 to 395dfe5 Compare November 30, 2024 01:37
@kdy1 kdy1 changed the base branch from kdy1/resolved-vc-turbopack-core to kdy1/resolved-vc-trivial November 30, 2024 01:37
@kdy1 kdy1 force-pushed the _kdy1/resolved-vc-next-api-last branch from 395dfe5 to 847a1b4 Compare November 30, 2024 01:39
@kdy1 kdy1 force-pushed the kdy1/resolved-vc-trivial branch 2 times, most recently from 3c7514b to fbedd42 Compare November 30, 2024 02:22
@kdy1 kdy1 force-pushed the _kdy1/resolved-vc-next-api-last branch from 847a1b4 to c2244c1 Compare November 30, 2024 02:22
@kdy1 kdy1 force-pushed the kdy1/resolved-vc-trivial branch from fbedd42 to fd14fcf Compare November 30, 2024 06:41
@kdy1 kdy1 force-pushed the _kdy1/resolved-vc-next-api-last branch from c2244c1 to b30875f Compare November 30, 2024 06:49
@kdy1 kdy1 force-pushed the kdy1/resolved-vc-trivial branch from f5dfdbe to 09a670c Compare November 30, 2024 09:03
@kdy1 kdy1 force-pushed the _kdy1/resolved-vc-next-api-last branch from b30875f to 3bec3b2 Compare November 30, 2024 09:04
@kdy1 kdy1 force-pushed the kdy1/resolved-vc-trivial branch from 169fbb8 to baed0b1 Compare December 3, 2024 01:58
@kdy1 kdy1 force-pushed the _kdy1/resolved-vc-next-api-last branch from 3bec3b2 to c1474b9 Compare December 3, 2024 01:58
@kdy1 kdy1 mentioned this pull request Dec 3, 2024
Merged
@ijjk
Copy link
Member

ijjk commented Dec 5, 2024 •
edited
Loading

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js _kdy1/resolved-vc-next-api-last Change
buildDuration 25.8s 22.9s N/A
buildDurationCached 22.1s 19.6s N/A
nodeModulesSize 409 MB 409 MB N/A
nextStartRea..uration (ms) 537ms 537ms ✓
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js _kdy1/resolved-vc-next-api-last Change
1187-HASH.js gzip 50.2 kB 50.2 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.3 kB 5.3 kB N/A
bccd1874-HASH.js gzip 53 kB 53 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 233 B 235 B N/A
main-HASH.js gzip 33.8 kB 33.7 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js _kdy1/resolved-vc-next-api-last Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Overall change 39.4 kB 39.4 kB ✓
Client Pages
vercel/next.js canary vercel/next.js _kdy1/resolved-vc-next-api-last Change
_app-HASH.js gzip 193 B 193 B ✓
_error-HASH.js gzip 193 B 193 B ✓
amp-HASH.js gzip 513 B 511 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB N/A
edge-ssr-HASH.js gzip 265 B 265 B ✓
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.44 kB 4.43 kB N/A
index-HASH.js gzip 268 B 268 B ✓
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B ✓
script-HASH.js gzip 397 B 397 B ✓
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 1.75 kB 1.75 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js _kdy1/resolved-vc-next-api-last Change
_buildManifest.js gzip 746 B 747 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js _kdy1/resolved-vc-next-api-last Change
index.html gzip 524 B 521 B N/A
link.html gzip 537 B 537 B ✓
withRouter.html gzip 520 B 519 B N/A
Overall change 537 B 537 B ✓
Edge SSR bundle Size
vercel/next.js canary vercel/next.js _kdy1/resolved-vc-next-api-last Change
edge-ssr.js gzip 128 kB 128 kB N/A
page.js gzip 203 kB 203 kB N/A
Overall change 0 B 0 B ✓
Middleware size
vercel/next.js canary vercel/next.js _kdy1/resolved-vc-next-api-last Change
middleware-b..fest.js gzip 669 B 668 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31 kB 31 kB N/A
edge-runtime..pack.js gzip 844 B 844 B ✓
Overall change 844 B 844 B ✓
Next Runtimes
vercel/next.js canary vercel/next.js _kdy1/resolved-vc-next-api-last Change
797-experime...dev.js gzip 322 B 322 B ✓
797.runtime.dev.js gzip 314 B 314 B ✓
app-page-exp...dev.js gzip 322 kB 322 kB ✓
app-page-exp..prod.js gzip 127 kB 127 kB ✓
app-page-tur..prod.js gzip 140 kB 140 kB ✓
app-page-tur..prod.js gzip 135 kB 135 kB ✓
app-page.run...dev.js gzip 312 kB 312 kB ✓
app-page.run..prod.js gzip 122 kB 122 kB ✓
app-route-ex...dev.js gzip 37.1 kB 37.1 kB ✓
app-route-ex..prod.js gzip 25.1 kB 25.1 kB ✓
app-route-tu..prod.js gzip 25.1 kB 25.1 kB ✓
app-route-tu..prod.js gzip 24.9 kB 24.9 kB ✓
app-route.ru...dev.js gzip 38.7 kB 38.7 kB ✓
app-route.ru..prod.js gzip 24.9 kB 24.9 kB ✓
pages-api-tu..prod.js gzip 9.56 kB 9.56 kB ✓
pages-api.ru...dev.js gzip 11.4 kB 11.4 kB ✓
pages-api.ru..prod.js gzip 9.56 kB 9.56 kB ✓
pages-turbo...prod.js gzip 21.3 kB 21.3 kB ✓
pages.runtim...dev.js gzip 27 kB 27 kB ✓
pages.runtim..prod.js gzip 21.3 kB 21.3 kB ✓
server.runti..prod.js gzip 916 kB 916 kB ✓
Overall change 2.35 MB 2.35 MB ✓
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js _kdy1/resolved-vc-next-api-last Change
0.pack gzip 2.03 MB 2.04 MB ⚠️ +2.15 kB
index.pack gzip 146 kB 145 kB N/A
Overall change 2.03 MB 2.04 MB ⚠️ +2.15 kB
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: 5819b95

@kdy1 kdy1 force-pushed the kdy1/resolved-vc-extras branch from 710fa56 to 3fb1e4c Compare December 5, 2024 06:42
@kdy1 kdy1 force-pushed the _kdy1/resolved-vc-next-api-last branch from 79bf67c to 518ba00 Compare December 5, 2024 06:43
mischnic
mischnic reviewed Dec 5, 2024
View reviewed changes
crates/next-api/src/route.rs
*data_endpoint = data_endpoint.resolve().await?;
if let Route::AppPage(routes) = self {
for route in routes {
route.resolve().await?;
Copy link
Contributor

@mischnic mischnic Dec 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to change AppPageRoute to contain ResolvedVc as well

Then this whole function can be removed

@kdy1 kdy1 force-pushed the kdy1/resolved-vc-extras branch 2 times, most recently from 2e94641 to 20b70e5 Compare December 5, 2024 08:31
@kdy1 kdy1 force-pushed the _kdy1/resolved-vc-next-api-last branch from 518ba00 to 335ea4e Compare December 5, 2024 08:31
@kdy1 kdy1 force-pushed the kdy1/resolved-vc-extras branch from 20b70e5 to 113bdb7 Compare December 8, 2024 04:57
@kdy1 kdy1 force-pushed the _kdy1/resolved-vc-next-api-last branch from 335ea4e to 111fba3 Compare December 8, 2024 04:57
@kdy1 kdy1 changed the base branch from kdy1/resolved-vc-extras to graphite-base/73367 December 8, 2024 07:41
@kdy1 Graphite App
Copy link
Member Author

kdy1 commented Dec 8, 2024 •
edited
Loading

Merge activity

  • Dec 8, 4:43 PM GMT+9: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..
  • Dec 8, 5:26 PM GMT+9: A user merged this pull request with Graphite.

@kdy1 kdy1 force-pushed the graphite-base/73367 branch from 113bdb7 to 6b9baaa Compare December 8, 2024 07:46
@kdy1 kdy1 changed the base branch from graphite-base/73367 to canary December 8, 2024 07:46
@kdy1 kdy1 merged commit f348241 into canary Dec 8, 2024
110 of 112 checks passed
@kdy1 kdy1 deleted the _kdy1/resolved-vc-next-api-last branch December 8, 2024 08:26
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mischnic mischnic mischnic left review comments

@bgw bgw bgw approved these changes

Assignees
No one assigned
Labels
created-by: Turbopack team PRs by the Turbopack team. locked Turbopack Related to Turbopack with Next.js.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kdy1 @ijjk @bgw @mischnic