Check write-access on prototype. #818
Closed
+21
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkzawa
reviewed
Jan 19, 2017
| return descr.writable ? obj : null | ||
| } | ||
| const proto = Object.getPrototypeOf(obj) | ||
| return proto ? getWritableProto(proto, p) : null |
There was a problem hiding this comment.
This traverses the prototype chain, returning the prototype object on which the property is defined. getOwnPropertyDescriptor returns the descriptor for the immediate/own properties only.
There was a problem hiding this comment.
Could we add a comment in the code to explain the motivation for this? Since it's a bit obscure
|
@dbo could you resolve the merge conflict ❤️ |
* zeit/master: (25 commits) Wrap render method created using class properties (2) (#856) Add Apollo example (#780) tweak font sizes again 🙈 Fix error fonts (#826) chore(package): update husky to version 0.13.0 (#853) Update styled-component docs (#841) Use ErrorDebug component on error of react-hot-loader (#852) Release 2.0.0-beta.18 bump `styled-jsx` chore(package): update styled-jsx to version 0.4.5 (#847) Make sure lastAppProps always have some value. (#829) chore(package): update babel-generator to version 6.22.0 (#833) chore(package): update babel-plugin-transform-async-to-generator to version 6.22.0 (#834) chore(package): update babel-plugin-transform-class-properties to version 6.22.0 (#835) chore(package): update babel-plugin-transform-object-rest-spread to version 6.22.0 (#836) chore(package): update babel-plugin-transform-runtime to version 6.22.0 (#837) chore(package): update babel-preset-es2015 to version 6.22.0 (#838) chore(package): update babel-preset-react to version 6.22.0 (#839) chore(package): update babel-runtime to version 6.22.0 (#840) chore(package): update babel-core to version 6.22.1 (#842) ... # Conflicts: # client/patch-react.js
|
I didn't aware of this PR. In my PR, if we can't override render method in the prototype stage, we'll do it in the runtime. Anyway, I'd like to take either one before we release 2.0 |
|
I also would be grateful if this issue would be resolved properly soon. It hinders us from progressing, still on an oudated 2.0-beta due to this issue. |
|
Sorry, I don't really understand the full scope of your change, and have to admit I don't really have much time for this problem. I am just eagerly waiting for: a) turn patching off by next.config or the like or b) check for write-access. |
|
@dbo Okay I will work on it. I will take your changes into it. |
Stats from current PRDefault Server ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Client Pages
Client Pages Modern
Client Build Manifests
Rendered Page Sizes
Serverless ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Client Pages
Client Pages Modern
Client Build Manifests
Serverless bundles
Commit: 3762e75 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a check whether the targeted prototype's render is writable before patching it.