-
Notifications
You must be signed in to change notification settings - Fork 199
Allow additional Node configure args with PKG_BUILD_CONFIGURE_ARGS #102
Conversation
2f89928
to
be8a184
Compare
@mladkau I made some updates: a. rename the env variable to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be documented in pkg and/or here. Maybe in this section: https://github.com/vercel/pkg#environment (waiting for a pr there before merge)
I lean toward hiding this as an advanced argument. |
I understand it but we should start document more things in both pkg and pkg-fetch projects otherwise it could be hard for new devs to start developing or even users that are looking for those advanced options need to read the code in order to know them I have spent many time looking at the code of both projects to undestand how they work at low level and some things are still obscure or not 100% clear to me |
be8a184
to
9aea2e9
Compare
Any update here? |
I think this could land but needs docs... |
^ Documenting it means that we are supposed to support it in some ways, but we can't support every exotic Node configure flag (and combination of) out there. The custom binaries would not be supported by us in any way. As such, I think this should be a hidden undocumented option. |
@leerob Could we merge this? |
This PR adds the ability to specify additional build options for the node build via an environment variable.
For example:
This can be used to address: vercel/pkg#555
The added functionality is a bit wider than /pull/72