This repository has been archived by the owner on Jan 3, 2024. It is now read-only.
added withArmFpu to build node for a specific arm fpu #267
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there!
The FPU instruction implementation on ARM cpu can vary and even being partial. (https://embeddedartistry.com/blog/2017/10/11/demystifying-arm-floating-point-compiler-options/)
For this reason our device using a SAMA5D3 cpu is not able to run node binaries compiled with the default configure options. (nodejs/node#28906)
So I added the ability to specify the arm fpu variant on the pkg-fetch command line.
In the process I also added the option to use ninja to speed up the build time. But honestly I never been able to build successfully node with ninja :D
Thank you
Andrea