Skip to content

Commit

Permalink
ci(workflow): limit datadog upload more strictly (#5178)
Browse files Browse the repository at this point in the history
### Description

<!--
  ✍️ Write a short summary of your work.
  If necessary, include relevant screenshots.
-->

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
  • Loading branch information
kwonoj authored Jun 2, 2023
1 parent f556a4a commit d1e1afe
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -1347,9 +1347,9 @@ jobs:
upload_test_results:
name: Upload Test results
needs:
- turbopack_rust_test1
- turbopack_rust_test2
if: always()
[determine_jobs, turbopack_rust_test1, turbopack_rust_test2]
# We have to set condition to always, since we want to upload test results for the failed tests as well.
if: ${{ always() }}
runs-on: ubuntu-latest
# Do not block CI if upload fails for some reason
continue-on-error: true
Expand All @@ -1372,9 +1372,6 @@ jobs:
with:
path: artifacts

- name: List test files
run: find ./artifacts/test_reports

- name: Upload
continue-on-error: true
env:
Expand Down

0 comments on commit d1e1afe

Please sign in to comment.