Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(workflow): limit datadog upload more strictly #5178

Merged
merged 1 commit into from
Jun 2, 2023
Merged

ci(workflow): limit datadog upload more strictly #5178

merged 1 commit into from
Jun 2, 2023

Conversation

kwonoj
Copy link
Contributor

@kwonoj kwonoj commented Jun 2, 2023

Description

Testing Instructions

@kwonoj kwonoj requested review from a team as code owners June 2, 2023 02:47
@vercel
Copy link

vercel bot commented Jun 2, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-cra-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jun 2, 2023 5:42am
examples-designsystem-docs 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jun 2, 2023 5:42am
9 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Jun 2, 2023 5:42am
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Jun 2, 2023 5:42am
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Jun 2, 2023 5:42am
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Jun 2, 2023 5:42am
examples-nonmonorepo ⬜️ Ignored (Inspect) Visit Preview Jun 2, 2023 5:42am
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Jun 2, 2023 5:42am
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Jun 2, 2023 5:42am
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Jun 2, 2023 5:42am
turbo-site ⬜️ Ignored (Inspect) Visit Preview Jun 2, 2023 5:42am

@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2023

✅ This change can build next-swc

@kwonoj kwonoj added the pr: automerge Kodiak will merge these automatically after checks pass label Jun 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2023

Linux Benchmark for 117c252

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 8565.27µs ± 47.70µs 8610.87µs ± 83.84µs +0.53%
bench_hmr_to_eval/Turbopack CSR/1000 modules 7725.08µs ± 55.12µs 7993.91µs ± 326.68µs +3.48%
bench_startup/Turbopack CSR/1000 modules 874.76ms ± 2.04ms 892.13ms ± 9.88ms +1.99%

@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2023

MacOS Benchmark for 117c252

Test Base PR % Significant %
bench_hmr_to_eval/Turbopack CSR/1000 modules 22.94ms ± 1.42ms 56.99ms ± 1.66ms +148.41% +108.12%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 26.80ms ± 0.20ms 27.00ms ± 0.17ms +0.73%
bench_hmr_to_eval/Turbopack CSR/1000 modules 22.94ms ± 1.42ms 56.99ms ± 1.66ms +148.41% +108.12%
bench_startup/Turbopack CSR/1000 modules 4649.39ms ± 757.22ms 3518.62ms ± 169.23ms -24.32%

@kwonoj kwonoj force-pushed the limit-datadog-upload branch from 99857b7 to 8ff5e2f Compare June 2, 2023 04:28
@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2023

Linux Benchmark for da5aa2a

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 8575.17µs ± 65.56µs 8734.26µs ± 89.99µs +1.86%
bench_hmr_to_eval/Turbopack CSR/1000 modules 7852.53µs ± 97.61µs 7911.83µs ± 188.98µs +0.76%
bench_startup/Turbopack CSR/1000 modules 887.46ms ± 1.54ms 887.58ms ± 4.60ms +0.01%

@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2023

MacOS Benchmark for da5aa2a

Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 25.47ms ± 0.23ms 23.00ms ± 0.44ms -9.70% -4.54%
bench_hmr_to_eval/Turbopack CSR/1000 modules 60.72ms ± 0.57ms 25.67ms ± 0.56ms -57.73% -55.05%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 25.47ms ± 0.23ms 23.00ms ± 0.44ms -9.70% -4.54%
bench_hmr_to_eval/Turbopack CSR/1000 modules 60.72ms ± 0.57ms 25.67ms ± 0.56ms -57.73% -55.05%
bench_startup/Turbopack CSR/1000 modules 2668.11ms ± 31.82ms 2598.01ms ± 24.41ms -2.63%

@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2023 •
edited
Loading

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Go lints
  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2023

Linux Benchmark for bf0fa6c

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 9065.83µs ± 73.95µs 9159.02µs ± 44.23µs +1.03%
bench_hmr_to_eval/Turbopack CSR/1000 modules 8435.10µs ± 65.37µs 8247.00µs ± 148.96µs -2.23%
bench_startup/Turbopack CSR/1000 modules 884.87ms ± 2.29ms 882.46ms ± 4.81ms -0.27%

@kwonoj kwonoj force-pushed the limit-datadog-upload branch from a539b2f to 8ff5e2f Compare June 2, 2023 06:50
@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2023

Linux Benchmark for 69ad0a0

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 8802.90µs ± 72.96µs 8777.94µs ± 55.87µs -0.28%
bench_hmr_to_eval/Turbopack CSR/1000 modules 7897.92µs ± 79.11µs 8079.96µs ± 265.41µs +2.30%
bench_startup/Turbopack CSR/1000 modules 894.52ms ± 8.86ms 889.55ms ± 4.53ms -0.55%

@kwonoj kwonoj merged commit d1e1afe into main Jun 2, 2023
@kwonoj kwonoj deleted the limit-datadog-upload branch June 2, 2023 08:10
@ForsakenHarmony ForsakenHarmony mentioned this pull request Jun 8, 2023
Merged
kodiakhq bot pushed a commit to vercel/next.js that referenced this pull request Jun 8, 2023
@ForsakenHarmony
update turbopack (#50819)
0d46361 
### Turbopack Updates
* vercel/turborepo#5156 
* vercel/turborepo#5159 
* vercel/turborepo#5162 
* vercel/turborepo#5161 

* vercel/turborepo#5174 
* vercel/turborepo#5178 
* vercel/turborepo#5121 
* vercel/turborepo#5200 
* vercel/turborepo#5207 
* vercel/turborepo#5211 
* vercel/turborepo#5210 
* vercel/turborepo#5221 
* vercel/turborepo#5218 
* vercel/turborepo#5226 
* vercel/turborepo#5139 
* vercel/turborepo#5227 
* vercel/turborepo#5189
hydRAnger pushed a commit to hydRAnger/next.js that referenced this pull request Jun 12, 2023
@ForsakenHarmony @hydRAnger
update turbopack (vercel#50819)
fea2213 
### Turbopack Updates
* vercel/turborepo#5156 
* vercel/turborepo#5159 
* vercel/turborepo#5162 
* vercel/turborepo#5161 

* vercel/turborepo#5174 
* vercel/turborepo#5178 
* vercel/turborepo#5121 
* vercel/turborepo#5200 
* vercel/turborepo#5207 
* vercel/turborepo#5211 
* vercel/turborepo#5210 
* vercel/turborepo#5221 
* vercel/turborepo#5218 
* vercel/turborepo#5226 
* vercel/turborepo#5139 
* vercel/turborepo#5227 
* vercel/turborepo#5189
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mehulkar mehulkar mehulkar approved these changes

@chris-olszewski chris-olszewski Awaiting requested review from chris-olszewski chris-olszewski is a code owner automatically assigned from vercel/turbo-oss

Assignees
No one assigned
Labels
area: ci pr: automerge Kodiak will merge these automatically after checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kwonoj @mehulkar