Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no longer build arm64 go builds #3838

Merged
merged 1 commit into from
Feb 21, 2023
Merged

no longer build arm64 go builds #3838

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions .github/workflows/turborepo-release-step-3.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,12 +141,17 @@ jobs:
mv go-artifacts/turbo-go-cross-${{ inputs.release_branch }}/turbo_linux_arm64/bin/* cli/dist-linux-arm64
chmod a+x cli/dist-linux-arm64/turbo
chmod a+x cli/dist-linux-arm64/go-turbo

# rust doesn't have a toolchain for arm + windows + gnu, so we just use the exe from the amd64 build
# and rely on windows' arm JITer to do the work for us. this is because the go exe cannot be build w/ msvc
cp -r go-artifacts/turbo-go-cross-${{ inputs.release_branch }}/turbo_windows_amd64_v1/bin/* cli/dist-windows-arm64
chmod a+x cli/dist-windows-arm64/turbo.exe
chmod a+x cli/dist-windows-arm64/go-turbo.exe

mv go-artifacts/turbo-go-cross-${{ inputs.release_branch }}/turbo_windows_amd64_v1/bin/* cli/dist-windows-amd64
chmod a+x cli/dist-windows-amd64/turbo.exe
chmod a+x cli/dist-windows-amd64/go-turbo.exe
mv go-artifacts/turbo-go-cross-${{ inputs.release_branch }}/turbo_windows_arm64/bin/* cli/dist-windows-arm64
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we want to continue shipping a windows/arm package, since we'll eventually be building it natively in Rust. So I think maybe this ought to be
mv go-artifacts/turbo-go-cross-${{ inputs.release_branch }}/turbo_windows_amd64_v1/bin/* cli/dist-windows-arm64

And keep the following lines?

chmod a+x cli/dist-windows-arm64/turbo.exe
chmod a+x cli/dist-windows-arm64/go-turbo.exe

mv go-artifacts/turbo-go-darwin-${{ inputs.release_branch }}/turbo_darwin_amd64_v1/bin/* cli/dist-darwin-amd64
chmod a+x cli/dist-darwin-amd64/turbo
chmod a+x cli/dist-darwin-amd64/go-turbo
Expand Down
1 change: 0 additions & 1 deletion cli/cross-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ builds:
targets:
- linux_arm64
- linux_amd64
- windows_arm64
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can delete the overrides entry below as well.

- windows_amd64
overrides:
- goos: linux
Expand Down