feat(turbopack_ecmascript): support partial tsconfig for the transform #3995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
9 Ignored Deployments
|
|
Benchmark for 6b964feClick to view benchmark
|
Benchmark for 1eae1dc
Click to view full benchmark
|
jridgewell
approved these changes
Mar 1, 2023
Comment on lines
+213
to
+214
| // Selectively picks up tsconfig.json values to construct | ||
| // swc transform's stripconfig. It doesn't account .swcrc config currently. |
kwonoj
force-pushed
the
feat-ts-config-transform
branch
from
e96b04c
to
66b5c44
Compare
kwonoj
added
the
pr: automerge
Benchmark for 489e4e3
Click to view full benchmark
|
kwonoj
force-pushed
the
feat-ts-config-transform
branch
from
66b5c44
to
ab55c9c
Compare
kwonoj
force-pushed
the
feat-ts-config-transform
branch
from
ab55c9c
to
6974cf8
Compare
Benchmark for 42bb845
Click to view full benchmark
|
mehulkar
pushed a commit
that referenced
this pull request
Mar 7, 2023
#3995) Resolves WEB-667, WEB-659. This PR allows to specify partial tsconfig (specifically, `useDefineForClassFields` / legacy decorators for now) into ecmatransform. There are few tsconfig options affect to the runtime output of typescript need to be specified when performing transform, useDefineForClassFields is one of them. For now, PR attempts to fix `test/development/basic/define-class-fields.test.ts` / `test/development/basic/legacy-decorators.test.ts` by enabling one options. .swcrc is still not being honored in this changes.
sokra
reviewed
Mar 7, 2023
Comment on lines
+144
to
+155
| let tsconfig = find_context_file(source.ident().path(), tsconfig()); | ||
| let tsconfig = match *tsconfig.await? { | ||
| FindContextFileResult::Found(path, _) => Some( | ||
| read_tsconfigs( | ||
| path.read(), | ||
| SourceAssetVc::new(path).into(), | ||
| node_cjs_resolve_options(path.root()), | ||
| ) | ||
| .await?, | ||
| ), | ||
| FindContextFileResult::NotFound(_) => None, | ||
| }; |
There was a problem hiding this comment.
This causes a lot of errors in front as tsconfig in node_modules is read:
C:\Repos\front\apps\vercel-site\node_modules\.pnpm\@vercel+analytics@0.1.9-beta.3_react@18.2.0\node_modules\@vercel\analytics\tsconfig.json
An issue occurred while parsing a tsconfig.json file.
extends doesn't resolve correctly
A tsconfig shouldn't be read in parse
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
vercel/turborepo#3995) Resolves WEB-667, WEB-659. This PR allows to specify partial tsconfig (specifically, `useDefineForClassFields` / legacy decorators for now) into ecmatransform. There are few tsconfig options affect to the runtime output of typescript need to be specified when performing transform, useDefineForClassFields is one of them. For now, PR attempts to fix `test/development/basic/define-class-fields.test.ts` / `test/development/basic/legacy-decorators.test.ts` by enabling one options. .swcrc is still not being honored in this changes.
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
vercel/turborepo#3995) Resolves WEB-667, WEB-659. This PR allows to specify partial tsconfig (specifically, `useDefineForClassFields` / legacy decorators for now) into ecmatransform. There are few tsconfig options affect to the runtime output of typescript need to be specified when performing transform, useDefineForClassFields is one of them. For now, PR attempts to fix `test/development/basic/define-class-fields.test.ts` / `test/development/basic/legacy-decorators.test.ts` by enabling one options. .swcrc is still not being honored in this changes.
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
vercel/turborepo#3995) Resolves WEB-667, WEB-659. This PR allows to specify partial tsconfig (specifically, `useDefineForClassFields` / legacy decorators for now) into ecmatransform. There are few tsconfig options affect to the runtime output of typescript need to be specified when performing transform, useDefineForClassFields is one of them. For now, PR attempts to fix `test/development/basic/define-class-fields.test.ts` / `test/development/basic/legacy-decorators.test.ts` by enabling one options. .swcrc is still not being honored in this changes.
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves WEB-667, WEB-659.
This PR allows to specify partial tsconfig (specifically,
useDefineForClassFields/ legacy decorators for now) into ecmatransform. There are few tsconfig options affect to the runtime output of typescript need to be specified when performing transform, useDefineForClassFields is one of them.For now, PR attempts to fix
test/development/basic/define-class-fields.test.ts/test/development/basic/legacy-decorators.test.tsby enabling one options. .swcrc is still not being honored in this changes.