Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "feat(turbopack_ecmascript): support partial tsconfig for the transform" #4117

Merged
merged 1 commit into from
Mar 8, 2023
Merged

Revert "feat(turbopack_ecmascript): support partial tsconfig for the transform" #4117

merged 1 commit into from
Mar 8, 2023

Conversation

kwonoj
Copy link
Contributor

@kwonoj kwonoj commented Mar 7, 2023

Reverts #3995

@kwonoj kwonoj requested a review from a team as a code owner March 7, 2023 23:59
@vercel
Copy link

vercel bot commented Mar 7, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 8, 2023 at 0:01AM (UTC)
9 Ignored Deployments
Name Status Preview Comments Updated
examples-basic-web ⬜️ Ignored (Inspect) Mar 8, 2023 at 0:01AM (UTC)
examples-cra-web ⬜️ Ignored (Inspect) Mar 8, 2023 at 0:01AM (UTC)
examples-designsystem-docs ⬜️ Ignored (Inspect) Mar 8, 2023 at 0:01AM (UTC)
examples-kitchensink-blog ⬜️ Ignored (Inspect) Mar 8, 2023 at 0:01AM (UTC)
examples-native-web ⬜️ Ignored (Inspect) Mar 8, 2023 at 0:01AM (UTC)
examples-nonmonorepo ⬜️ Ignored (Inspect) Mar 8, 2023 at 0:01AM (UTC)
examples-svelte-web ⬜️ Ignored (Inspect) Mar 8, 2023 at 0:01AM (UTC)
examples-tailwind-web ⬜️ Ignored (Inspect) Mar 8, 2023 at 0:01AM (UTC)
examples-vite-web ⬜️ Ignored (Inspect) Mar 8, 2023 at 0:01AM (UTC)

@linear
Copy link

linear bot commented Mar 8, 2023

Issue reopened: WEB-667 test/development/basic/legacy-decorators.test.ts: support legacy decorators in typescript

@linear
Copy link

linear bot commented Mar 8, 2023

Issue reopened: WEB-659 test/development/basic/define-class-fields.test.ts : support tsconfig useDefineForClassFields

@kwonoj kwonoj merged commit f13af82 into main Mar 8, 2023
@kwonoj kwonoj deleted the revert-3995-feat-ts-config-transform branch March 8, 2023 00:03
@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2023 •
edited
Loading

🟢 CI successful 🟢

Thanks

@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2023

Benchmark for cc6b900

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 9107.34µs ± 66.58µs 9184.06µs ± 50.19µs +0.84%
bench_hmr_to_commit/Turbopack RCC/1000 modules 13.07ms ± 0.07ms 12.67ms ± 0.21ms -3.07%
bench_hmr_to_commit/Turbopack RSC/1000 modules 496.65ms ± 0.61ms 498.79ms ± 1.37ms +0.43%
bench_hmr_to_commit/Turbopack SSR/1000 modules 9449.85µs ± 49.24µs 9495.61µs ± 20.70µs +0.48%
bench_hmr_to_eval/Turbopack CSR/1000 modules 8149.15µs ± 46.98µs 8121.95µs ± 32.32µs -0.33%
bench_hmr_to_eval/Turbopack RCC/1000 modules 11.67ms ± 0.10ms 11.45ms ± 0.17ms -1.85%
bench_hmr_to_eval/Turbopack SSR/1000 modules 8406.36µs ± 28.22µs 8415.53µs ± 32.40µs +0.11%
bench_hydration/Turbopack RCC/1000 modules 3543.71ms ± 12.82ms 3530.02ms ± 10.42ms -0.39%
bench_hydration/Turbopack RSC/1000 modules 3163.96ms ± 8.05ms 3171.52ms ± 9.95ms +0.24%
bench_hydration/Turbopack SSR/1000 modules 3241.70ms ± 7.32ms 3241.24ms ± 5.61ms -0.01%
bench_startup/Turbopack CSR/1000 modules 2540.74ms ± 6.00ms 2521.95ms ± 8.11ms -0.74%
bench_startup/Turbopack RCC/1000 modules 2078.73ms ± 2.48ms 2079.45ms ± 3.23ms +0.03%
bench_startup/Turbopack RSC/1000 modules 2015.12ms ± 6.25ms 2014.82ms ± 7.68ms -0.01%
bench_startup/Turbopack SSR/1000 modules 1997.66ms ± 1.78ms 1996.59ms ± 2.46ms -0.05%

@kdy1 kdy1 mentioned this pull request Mar 8, 2023
Merged
kodiakhq bot pushed a commit to vercel/next.js that referenced this pull request Mar 8, 2023
@kdy1
Update turbopack to 230308.1 (#46909)
37b0349 
## Bugfixes

 - vercel/turborepo#3526
 - vercel/turborepo#4084
 - vercel/turborepo#4083
 - vercel/turborepo#4067
 - vercel/turborepo#3959
 - vercel/turborepo#4060
 - vercel/turborepo#4081
 - vercel/turborepo#4103
 - vercel/turborepo#4100
 - vercel/turborepo#4108
 - vercel/turborepo#4101
 - vercel/turborepo#4112
 - vercel/turborepo#3956
 - vercel/turborepo#4118
 - vercel/turborepo#4117

## Feature

 - vercel/turborepo#4058
  - vercel/turborepo#4013
  - vercel/turborepo#4005
  - vercel/turborepo#4001
  - vercel/turborepo#3839
  - vercel/turborepo#4017
  - vercel/turborepo#4086
  - vercel/turborepo#4067

## Performance

  - vercel/turborepo#4040
  - vercel/turborepo#4110

## Refactor

 - vercel/turborepo#4098
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
@kwonoj
Revert "feat(turbopack_ecmascript): support partial tsconfig for the …
ea66746 
…transform" (vercel/turborepo#4117)

Reverts vercel/turborepo#3995
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@kwonoj
Revert "feat(turbopack_ecmascript): support partial tsconfig for the …
f31fd35 
…transform" (vercel/turborepo#4117)

Reverts vercel/turborepo#3995
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
@kwonoj
Revert "feat(turbopack_ecmascript): support partial tsconfig for the …
1b996cf 
…transform" (vercel/turborepo#4117)

Reverts vercel/turborepo#3995
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sokra sokra sokra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kwonoj @sokra