feat(contextcondition): support InPath contextcondition #4521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
9 Ignored Deployments
|
|
✅ This changes can build |
🟢 CI successful 🟢Thanks |
kdy1
approved these changes
Apr 11, 2023
sokra
requested changes
Apr 11, 2023
kwonoj
force-pushed
the
context-condition-test
branch
from
797378c to
0c06c8f
Compare
kwonoj
force-pushed
the
context-condition-test
branch
from
0c06c8f to
824a79b
Compare
Benchmark for 51f96a4Click to view benchmark
|
kwonoj
force-pushed
the
context-condition-test
branch
from
824a79b to
923de39
Compare
Benchmark for 1802874Click to view benchmark
|
sokra
reviewed
Apr 15, 2023
crates/turbopack/src/condition.rs
Outdated
| path.fs | ||
| .root() | ||
| .await | ||
| .map_or(false, |root| context.is_inside(&root)) |
There was a problem hiding this comment.
This ignores the error here, but it's better to propagate the error upwards
There was a problem hiding this comment.
So change fn matches(...) -> bool signature to fn matches(..) -> Result<bool>?
sokra
reviewed
Apr 15, 2023
kwonoj
force-pushed
the
context-condition-test
branch
from
923de39 to
dd6b308
Compare
Benchmark for b669582
Click to view full benchmark
|
kwonoj
force-pushed
the
context-condition-test
branch
from
dd6b308 to
b2dce94
Compare
sokra
changed the title
sokra
approved these changes
Apr 18, 2023
kwonoj
added
the
pr: automerge
Benchmark for 3f7a125Click to view benchmark
|
sokra
added a commit
to vercel/next.js
that referenced
this pull request
Apr 20, 2023
### What?
add support for blur placeholder generation to turbopack
add `StructuredImageModuleType` which is used with `ModuleType::Custom`
to allow importing an image as `{ url, width, height, blurDataURL,
blurWidth, blurHeight }`
in contrast to next.js with webpack this will also generate blur
placeholder in development instead of using a _next/image reference.
This should lead to more production-like experience (at the cost of a
little bit of compilation time).
turbo PR: vercel/turborepo#4621
### Why?
Turbopack was crashing on `placeholder="blur"` before.
fixes WEB-534
### Turbopack changes
* vercel/turborepo#4521 <!-- OJ Kwon -
feat(contextcondition): support InPath contextcondition -->
* vercel/turborepo#4601 <!-- Alex Kirszenberg -
Chunking Context Refactor pt. 3: Address PR comments from pt. 2 -->
* vercel/turborepo#4623 <!-- Tobias Koppers -
exclude turborepo from turbopack bench tests -->
* vercel/turborepo#4399 <!-- Leah - support
require.context -->
* vercel/turborepo#4610 <!-- OJ Kwon - test(subset):
add mdx test into subset -->
* vercel/turborepo#4624 <!-- Tobias Koppers - run
benchmarks on windows and macOS too -->
* vercel/turborepo#4620 <!-- Alex Kirszenberg - Make
ContainmentTree fully generic -->
* vercel/turborepo#4600 <!-- Tobias Koppers - add
getChunkPath method -->
* vercel/turborepo#4621 <!-- Tobias Koppers - add
turbopack-image -->
* vercel/turborepo#4639 <!-- Tobias Koppers -
restrict snapshot path for windows path length limit -->
* vercel/turborepo#4641 <!-- Tobias Koppers - put
webp behind a feature flag -->
NicholasLYang
pushed a commit
to NicholasLYang/turbo
that referenced
this pull request
Apr 21, 2023
### Description Attempt to close WEB-862. Currently turbopack in next-swc applies all of moduleoptionscontext into any kind of internal assets. Current available contextcondition (`ContextCondition::InDirectory`) does not gives enough context to determine where it comes from, makes non trivial to determine if given context need to be treated differently. ~I'm trying to workaround by supplying addtional context for the filesystemkind, and caller can use it for creating a new contextcondition. In case of turbopack, I assume any embedded assets in the binary won't be an external / user's. Next-swc will assign a new condition like vercel/next.js@canary...client-context-embedded-fs#diff-92086db0c6bc192f76dab5d612a562df8fddffea05244c1c00d58e7288879e11R213-R214.~ ~Still bit unsure if this is a legit apporach or would be better way to go. PR is for the POC + further improvement based on the feedback.~ Per review suggestion, this PR now supports `InPath(FileSystemVc)` as new condition instead.
kodiakhq bot
pushed a commit
to vercel/next.js
that referenced
this pull request
May 2, 2023
### What? This is necessary changes for the WEB-862, however dependent to vercel/turborepo#4521.
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
…repo#4521) ### Description Attempt to close WEB-862. Currently turbopack in next-swc applies all of moduleoptionscontext into any kind of internal assets. Current available contextcondition (`ContextCondition::InDirectory`) does not gives enough context to determine where it comes from, makes non trivial to determine if given context need to be treated differently. ~I'm trying to workaround by supplying addtional context for the filesystemkind, and caller can use it for creating a new contextcondition. In case of turbopack, I assume any embedded assets in the binary won't be an external / user's. Next-swc will assign a new condition like canary...client-context-embedded-fs#diff-92086db0c6bc192f76dab5d612a562df8fddffea05244c1c00d58e7288879e11R213-R214.~ ~Still bit unsure if this is a legit apporach or would be better way to go. PR is for the POC + further improvement based on the feedback.~ Per review suggestion, this PR now supports `InPath(FileSystemVc)` as new condition instead.
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
…repo#4521) ### Description Attempt to close WEB-862. Currently turbopack in next-swc applies all of moduleoptionscontext into any kind of internal assets. Current available contextcondition (`ContextCondition::InDirectory`) does not gives enough context to determine where it comes from, makes non trivial to determine if given context need to be treated differently. ~I'm trying to workaround by supplying addtional context for the filesystemkind, and caller can use it for creating a new contextcondition. In case of turbopack, I assume any embedded assets in the binary won't be an external / user's. Next-swc will assign a new condition like canary...client-context-embedded-fs#diff-92086db0c6bc192f76dab5d612a562df8fddffea05244c1c00d58e7288879e11R213-R214.~ ~Still bit unsure if this is a legit apporach or would be better way to go. PR is for the POC + further improvement based on the feedback.~ Per review suggestion, this PR now supports `InPath(FileSystemVc)` as new condition instead.
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
…repo#4521) ### Description Attempt to close WEB-862. Currently turbopack in next-swc applies all of moduleoptionscontext into any kind of internal assets. Current available contextcondition (`ContextCondition::InDirectory`) does not gives enough context to determine where it comes from, makes non trivial to determine if given context need to be treated differently. ~I'm trying to workaround by supplying addtional context for the filesystemkind, and caller can use it for creating a new contextcondition. In case of turbopack, I assume any embedded assets in the binary won't be an external / user's. Next-swc will assign a new condition like canary...client-context-embedded-fs#diff-92086db0c6bc192f76dab5d612a562df8fddffea05244c1c00d58e7288879e11R213-R214.~ ~Still bit unsure if this is a legit apporach or would be better way to go. PR is for the POC + further improvement based on the feedback.~ Per review suggestion, this PR now supports `InPath(FileSystemVc)` as new condition instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Attempt to close WEB-862.
Currently turbopack in next-swc applies all of moduleoptionscontext into any kind of internal assets. Current available contextcondition (
ContextCondition::InDirectory) does not gives enough context to determine where it comes from, makes non trivial to determine if given context need to be treated differently.I'm trying to workaround by supplying addtional context for the filesystemkind, and caller can use it for creating a new contextcondition. In case of turbopack, I assume any embedded assets in the binary won't be an external / user's. Next-swc will assign a new condition like vercel/next.js@canary...client-context-embedded-fs#diff-92086db0c6bc192f76dab5d612a562df8fddffea05244c1c00d58e7288879e11R213-R214.Still bit unsure if this is a legit apporach or would be better way to go. PR is for the POC + further improvement based on the feedback.Per review suggestion, this PR now supports
InPath(FileSystemVc)as new condition instead.