Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restrict snapshot path for windows path length limit #4639

Merged
merged 2 commits into from
Apr 19, 2023

Conversation

sokra
Copy link
Member

@sokra sokra commented Apr 19, 2023

Description

windows...

@sokra sokra requested a review from a team as a code owner April 19, 2023 17:07
@vercel
Copy link

vercel bot commented Apr 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-cra-web 🔄 Building (Inspect) Apr 19, 2023 5:14pm
examples-gatsby-web 🔄 Building (Inspect) Apr 19, 2023 5:14pm
examples-nonmonorepo 🔄 Building (Inspect) Apr 19, 2023 5:14pm
examples-svelte-web 🔄 Building (Inspect) Apr 19, 2023 5:14pm
7 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Apr 19, 2023 5:14pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Apr 19, 2023 5:14pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Apr 19, 2023 5:14pm
examples-native-web ⬜️ Ignored (Inspect) Apr 19, 2023 5:14pm
examples-tailwind-web ⬜️ Ignored (Inspect) Apr 19, 2023 5:14pm
examples-vite-web ⬜️ Ignored (Inspect) Apr 19, 2023 5:14pm
turbo-site ⬜️ Ignored (Inspect) Visit Preview Apr 19, 2023 5:14pm

@github-actions
Copy link
Contributor

✅ This changes can build next-swc

@sokra sokra enabled auto-merge (squash) April 19, 2023 17:20
@sokra sokra disabled auto-merge April 19, 2023 17:25
@sokra sokra merged commit a5bd582 into main Apr 19, 2023
@sokra sokra deleted the sokra/fix-next-build-failure branch April 19, 2023 17:25
@github-actions
Copy link
Contributor

github-actions bot commented Apr 19, 2023

🟢 CI successful 🟢

Thanks

sokra added a commit to vercel/next.js that referenced this pull request Apr 20, 2023
### What?

add support for blur placeholder generation to turbopack

add `StructuredImageModuleType` which is used with `ModuleType::Custom`
to allow importing an image as `{ url, width, height, blurDataURL,
blurWidth, blurHeight }`

in contrast to next.js with webpack this will also generate blur
placeholder in development instead of using a _next/image reference.
This should lead to more production-like experience (at the cost of a
little bit of compilation time).

turbo PR: vercel/turborepo#4621

### Why?

Turbopack was crashing on `placeholder="blur"` before.

fixes WEB-534

### Turbopack changes

* vercel/turborepo#4521 <!-- OJ Kwon -
feat(contextcondition): support InPath contextcondition -->
* vercel/turborepo#4601 <!-- Alex Kirszenberg -
Chunking Context Refactor pt. 3: Address PR comments from pt. 2 -->
* vercel/turborepo#4623 <!-- Tobias Koppers -
exclude turborepo from turbopack bench tests -->
* vercel/turborepo#4399 <!-- Leah - support
require.context -->
* vercel/turborepo#4610 <!-- OJ Kwon - test(subset):
add mdx test into subset -->
* vercel/turborepo#4624 <!-- Tobias Koppers - run
benchmarks on windows and macOS too -->
* vercel/turborepo#4620 <!-- Alex Kirszenberg - Make
ContainmentTree fully generic -->
* vercel/turborepo#4600 <!-- Tobias Koppers - add
getChunkPath method -->
* vercel/turborepo#4621 <!-- Tobias Koppers - add
turbopack-image -->
* vercel/turborepo#4639 <!-- Tobias Koppers -
restrict snapshot path for windows path length limit -->
* vercel/turborepo#4641 <!-- Tobias Koppers - put
webp behind a feature flag -->
NicholasLYang pushed a commit to NicholasLYang/turbo that referenced this pull request Apr 21, 2023
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants