Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(workflow): limit datadog upload more strictly #5178

Merged
merged 1 commit into from
Jun 2, 2023
Merged

ci(workflow): limit datadog upload more strictly #5178

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1345,9 +1345,9 @@ jobs:
upload_test_results:
name: Upload Test results
needs:
- turbopack_rust_test1
- turbopack_rust_test2
if: always()
[determine_jobs, turbopack_rust_test1, turbopack_rust_test2]
# We have to set condition to always, since we want to upload test results for the failed tests as well.
if: ${{ always() }}
runs-on: ubuntu-latest
# Do not block CI if upload fails for some reason
continue-on-error: true
Expand All @@ -1370,9 +1370,6 @@ jobs:
with:
path: artifacts

- name: List test files
run: find ./artifacts/test_reports

- name: Upload
continue-on-error: true
env:
Expand Down