improve dynamic reexporting #5452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`__turbopack_export_namespace__` counts as dynamic use Proxy to correctly reexport non-enumerable or changing objects
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
10 Ignored Deployments
|
|
|
✅ This change can build |
Linux Benchmark for 53242ecClick to view benchmark
|
Linux Benchmark for 63badc6Click to view benchmark
|
Windows Benchmark for 63badc6
Click to view full benchmark
|
alexkirsz
reviewed
Jul 4, 2023
crates/turbopack-ecmascript-runtime/js/src/shared/runtime-utils.ts
Outdated
Show resolved
Hide resolved
crates/turbopack-ecmascript-runtime/js/src/shared/runtime-utils.ts
Outdated
Show resolved
Hide resolved
crates/turbopack-ecmascript-runtime/js/src/shared/runtime-utils.ts
Outdated
Show resolved
Hide resolved
crates/turbopack-ecmascript-runtime/js/src/shared/runtime-utils.ts
Outdated
Show resolved
Hide resolved
| asserts.props.iter().any(|assert| { | ||
| assert | ||
| .as_prop() | ||
| .and_then(|prop| prop.as_key_value()) | ||
| .and_then(|kv| kv.key.as_ident()) | ||
| .map_or(true, |ident| &*ident.sym != TURBOPACK_HELPER) | ||
| .map_or(false, |ident| &*ident.sym == TURBOPACK_HELPER) |
There was a problem hiding this comment.
Was this broken before, or was it used some other way?
| || &*i.sym == "exports" | ||
| || &*i.sym == "__turbopack_export_value__" | ||
| { | ||
| if &*i.sym == "module" || &*i.sym == "exports" { |
There was a problem hiding this comment.
Does this only work if the ident is unresolved? e.g. will it false positive const module = {}?
There was a problem hiding this comment.
Yes that's broken in that case. It's only a difference between no exports and commonjs exports, and doesn't matter at runtime. It generates a bit less code for "no exports", but nevermind...
There was a problem hiding this comment.
Can you add a comment explaining this, so we know that this is broken but it doesn't actually matter?
Co-authored-by: Alex Kirszenberg <alex.kirszenberg@vercel.com>
Linux Benchmark for b1a8180Click to view benchmark
|
alexkirsz
reviewed
Jul 4, 2023
| @@ -99,15 +99,15 @@ function dynamicExport(module: Module, object: Record<string, any>) { | |||
| ) { | |||
| return Reflect.get(target, prop); | |||
| } | |||
| for (const obj of reexportedObjects) { | |||
There was a problem hiding this comment.
Didn't think you'd need this with reexportedObjects being clearly set to a defined value above.
Linux Benchmark for 89ed02bClick to view benchmark
|
alexkirsz
approved these changes
Jul 4, 2023
Comment on lines
+608
to
+609
| DetectedDynamicExportType::Namespace => EcmascriptExports::DynamicNamespace, | ||
| DetectedDynamicExportType::Value => EcmascriptExports::Value, |
There was a problem hiding this comment.
hmm, I think this unfortunately breaks my async module implementation 🙃
shuding
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 8, 2023
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
### Description This fixes some problems when `export * from "client component"`, as `"use client"` creates a non-enumerable Proxy object, so we need to really redirect property access. * `__turbopack_export_namespace__` counts as dynamic * use Proxy to correctly reexport non-enumerable or changing objects --------- Co-authored-by: Alex Kirszenberg <alex.kirszenberg@vercel.com>
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description This fixes some problems when `export * from "client component"`, as `"use client"` creates a non-enumerable Proxy object, so we need to really redirect property access. * `__turbopack_export_namespace__` counts as dynamic * use Proxy to correctly reexport non-enumerable or changing objects --------- Co-authored-by: Alex Kirszenberg <alex.kirszenberg@vercel.com>
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
### Description This fixes some problems when `export * from "client component"`, as `"use client"` creates a non-enumerable Proxy object, so we need to really redirect property access. * `__turbopack_export_namespace__` counts as dynamic * use Proxy to correctly reexport non-enumerable or changing objects --------- Co-authored-by: Alex Kirszenberg <alex.kirszenberg@vercel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes some problems when
export * from "client component", as"use client"creates a non-enumerable Proxy object, so we need to really redirect property access.__turbopack_export_namespace__counts as dynamic