New FileSystemPath methods: with_extension and file_stem #5395

alexkirsz · 2023-06-27T09:17:28Z

Description

Testing Instructions

vercel · 2023-06-27T09:17:32Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
examples-basic-web	🔄 Building (Inspect)	Visit Preview	💬 Add feedback	Jul 3, 2023 1:26pm
examples-kitchensink-blog	🔄 Building (Inspect)	Visit Preview	💬 Add feedback	Jul 3, 2023 1:26pm
turbo-site	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 3, 2023 1:26pm

8 Ignored Deployments

Name	Status	Preview	Updated (UTC)
examples-cra-web	⬜️ Ignored (Inspect)	Visit Preview	Jul 3, 2023 1:26pm
examples-designsystem-docs	⬜️ Ignored (Inspect)	Visit Preview	Jul 3, 2023 1:26pm
examples-gatsby-web	⬜️ Ignored (Inspect)	Visit Preview	Jul 3, 2023 1:26pm
examples-native-web	⬜️ Ignored (Inspect)	Visit Preview	Jul 3, 2023 1:26pm
examples-nonmonorepo	⬜️ Ignored (Inspect)	Visit Preview	Jul 3, 2023 1:26pm
examples-svelte-web	⬜️ Ignored (Inspect)	Visit Preview	Jul 3, 2023 1:26pm
examples-tailwind-web	⬜️ Ignored (Inspect)	Visit Preview	Jul 3, 2023 1:26pm
examples-vite-web	⬜️ Ignored (Inspect)	Visit Preview	Jul 3, 2023 1:26pm

alexkirsz · 2023-06-27T09:17:41Z

Current dependencies on/for this PR:

main
- PR New FileSystemPath methods: with_extension and file_stem #5395 👈
  - PR Add support for CSS client references #5397
    - PR Configure the path of the Node.js entry chunk #5398
      - PR Misc. changes to support App Router build #5448
  - PR Fix rebase error with ESM interop #5396

This comment was auto-generated by Graphite.

github-actions · 2023-06-27T09:22:31Z

✅ This change can build next-swc

github-actions · 2023-06-27T09:38:16Z

🟢 CI successful 🟢

Thanks

github-actions · 2023-06-27T09:45:52Z

Linux Benchmark for `8b98e2b`

Click to view benchmark

Test	Base	PR	%
bench_hmr_to_commit/Turbopack CSR/1000 modules	6325.74µs ± 28.41µs	6308.51µs ± 34.68µs	-0.27%
bench_hmr_to_eval/Turbopack CSR/1000 modules	5914.10µs ± 29.62µs	6058.04µs ± 164.97µs	+2.43%
bench_startup/Turbopack CSR/1000 modules	913.60ms ± 2.14ms	908.78ms ± 2.06ms	-0.53%

github-actions · 2023-06-27T10:26:24Z

MacOS Benchmark for `8b98e2b`

Test	Base	PR	%	Significant %
bench_startup/Turbopack CSR/1000 modules	9037.60ms ± 2291.96ms	3779.67ms ± 119.31ms	-58.18%	-9.78%

Click to view full benchmark

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	26.97ms ± 0.20ms	27.32ms ± 0.16ms	+1.32%
bench_hmr_to_eval/Turbopack CSR/1000 modules	26.48ms ± 0.22ms	27.30ms ± 1.13ms	+3.13%
bench_startup/Turbopack CSR/1000 modules	9037.60ms ± 2291.96ms	3779.67ms ± 119.31ms	-58.18%	-9.78%

crates/turbo-tasks-fs/src/lib.rs

crates/turbo-tasks-fs/src/virtual_fs.rs

jridgewell

LGTM after @sokra's comments are taken care of.

crates/turbo-tasks-fs/src/virtual_fs.rs

crates/turbo-tasks-fs/src/lib.rs

github-actions · 2023-06-28T18:06:30Z

Linux Benchmark for `c8391e7`

Click to view benchmark

Test	Base	PR	%
bench_hmr_to_commit/Turbopack CSR/1000 modules	10.56ms ± 0.10ms	10.23ms ± 0.15ms	-3.08%
bench_hmr_to_eval/Turbopack CSR/1000 modules	9929.50µs ± 112.94µs	10.15ms ± 0.16ms	+2.26%
bench_startup/Turbopack CSR/1000 modules	1093.57ms ± 2.23ms	1092.18ms ± 3.92ms	-0.13%

github-actions · 2023-06-28T18:42:25Z

Windows Benchmark for `c8391e7`

Test	Base	PR	%	Significant %
bench_startup/Turbopack CSR/1000 modules	3986.71ms ± 16.99ms	3898.67ms ± 12.22ms	-2.21%	-0.75%

Click to view full benchmark

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	15.68ms ± 0.03ms	15.91ms ± 0.09ms	+1.47%
bench_hmr_to_eval/Turbopack CSR/1000 modules	16.03ms ± 0.19ms	15.80ms ± 0.03ms	-1.44%
bench_startup/Turbopack CSR/1000 modules	3986.71ms ± 16.99ms	3898.67ms ± 12.22ms	-2.21%	-0.75%

crates/turbo-tasks-fs/src/lib.rs

github-actions · 2023-07-03T11:57:06Z

Linux Benchmark for `9dc695a`

Click to view benchmark

Test	Base	PR	%
bench_hmr_to_commit/Turbopack CSR/1000 modules	6726.22µs ± 37.39µs	6549.31µs ± 53.03µs	-2.63%
bench_hmr_to_eval/Turbopack CSR/1000 modules	6216.73µs ± 58.82µs	6248.20µs ± 66.39µs	+0.51%
bench_startup/Turbopack CSR/1000 modules	910.23ms ± 1.24ms	916.89ms ± 4.10ms	+0.73%

github-actions · 2023-07-03T12:26:13Z

MacOS Benchmark for `9dc695a`

Test	Base	PR	%	Significant %
bench_hmr_to_eval/Turbopack CSR/1000 modules	27.36ms ± 0.27ms	24.70ms ± 0.41ms	-9.69%	-4.85%
bench_startup/Turbopack CSR/1000 modules	7487.37ms ± 1026.66ms	3731.53ms ± 78.18ms	-50.16%	-28.45%

Click to view full benchmark

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	28.20ms ± 0.15ms	28.17ms ± 0.08ms	-0.08%
bench_hmr_to_eval/Turbopack CSR/1000 modules	27.36ms ± 0.27ms	24.70ms ± 0.41ms	-9.69%	-4.85%
bench_startup/Turbopack CSR/1000 modules	7487.37ms ± 1026.66ms	3731.53ms ± 78.18ms	-50.16%	-28.45%

### Description  ### Testing Instructions

github-actions · 2023-07-03T13:10:48Z

Linux Benchmark for `3954c0e`

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	10.76ms ± 0.04ms	10.58ms ± 0.04ms	-1.68%	-0.16%

Click to view full benchmark

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	10.76ms ± 0.04ms	10.58ms ± 0.04ms	-1.68%	-0.16%
bench_hmr_to_eval/Turbopack CSR/1000 modules	9840.63µs ± 93.38µs	9832.78µs ± 129.45µs	-0.08%
bench_startup/Turbopack CSR/1000 modules	1115.60ms ± 1.84ms	1121.81ms ± 7.59ms	+0.56%

github-actions · 2023-07-03T13:46:04Z

Linux Benchmark for 45c662f

Test	Base	PR	%	Significant %
bench_startup/Turbopack CSR/1000 modules	918.20ms ± 0.80ms	928.21ms ± 3.59ms	+1.09%	+0.13%

Click to view full benchmark

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	6482.94µs ± 30.02µs	6519.63µs ± 22.26µs	+0.57%
bench_hmr_to_eval/Turbopack CSR/1000 modules	6050.14µs ± 28.26µs	6114.96µs ± 32.92µs	+1.07%
bench_startup/Turbopack CSR/1000 modules	918.20ms ± 0.80ms	928.21ms ± 3.59ms	+1.09%	+0.13%

github-actions · 2023-07-03T14:05:42Z

Windows Benchmark for 45c662f

Test	Base	PR	%	Significant %
bench_startup/Turbopack CSR/1000 modules	2621.80ms ± 9.37ms	2708.40ms ± 30.10ms	+3.30%	+0.29%

Click to view full benchmark

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	15.76ms ± 0.05ms	15.75ms ± 0.09ms	-0.04%
bench_hmr_to_eval/Turbopack CSR/1000 modules	15.72ms ± 0.08ms	15.66ms ± 0.03ms	-0.34%
bench_startup/Turbopack CSR/1000 modules	2621.80ms ± 9.37ms	2708.40ms ± 30.10ms	+3.30%	+0.29%

github-actions · 2023-07-03T14:14:47Z

MacOS Benchmark for 45c662f

Test	Base	PR	%	Significant %
bench_startup/Turbopack CSR/1000 modules	9533.98ms ± 555.68ms	3631.49ms ± 113.52ms	-61.91%	-54.19%

Click to view full benchmark

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	28.27ms ± 0.12ms	28.37ms ± 0.15ms	+0.35%
bench_hmr_to_eval/Turbopack CSR/1000 modules	27.86ms ± 0.45ms	27.83ms ± 0.51ms	-0.11%
bench_startup/Turbopack CSR/1000 modules	9533.98ms ± 555.68ms	3631.49ms ± 113.52ms	-61.91%	-54.19%

* vercel/turborepo#5395 * vercel/turborepo#5452

…orepo#5395) ### Description  ### Testing Instructions

alexkirsz requested a review from a team as a code owner June 27, 2023 09:17

turbo-orchestrator bot added the team: turbopack label Jun 27, 2023

alexkirsz mentioned this pull request Jun 27, 2023

Fix rebase error with ESM interop #5396

Merged

vercel bot deployed to Preview – turbo-site June 27, 2023 09:18 View deployment

This was referenced Jun 27, 2023

Add support for CSS client references #5397

Merged

Configure the path of the Node.js entry chunk #5398

Merged

sokra requested changes Jun 27, 2023

View reviewed changes

crates/turbo-tasks-fs/src/lib.rs Outdated Show resolved Hide resolved

crates/turbo-tasks-fs/src/lib.rs Outdated Show resolved Hide resolved

sokra requested changes Jun 27, 2023

View reviewed changes

crates/turbo-tasks-fs/src/virtual_fs.rs Outdated Show resolved Hide resolved

crates/turbo-tasks-fs/src/virtual_fs.rs Show resolved Hide resolved

jridgewell approved these changes Jun 27, 2023

View reviewed changes

crates/turbo-tasks-fs/src/virtual_fs.rs Outdated Show resolved Hide resolved

crates/turbo-tasks-fs/src/lib.rs Outdated Show resolved Hide resolved

alexkirsz requested a review from sokra July 3, 2023 11:25

alexkirsz force-pushed the alexkirsz/web-866-fspath-extensions branch from e195ea7 to f5b8530 Compare July 3, 2023 11:27

vercel bot deployed to Preview – turbo-site July 3, 2023 11:28 View deployment

sokra reviewed Jul 3, 2023

View reviewed changes

crates/turbo-tasks-fs/src/lib.rs Outdated Show resolved Hide resolved

sokra approved these changes Jul 3, 2023

View reviewed changes

alexkirsz added 6 commits July 3, 2023 15:01

New FileSystemPath methods: with_extension and file_stem

aeddbe4

Add tests

f6bd2f5

Fix rebase error with ESM interop (#5396)

7932175

### Description  ### Testing Instructions

PR comments

3b7a4ab

PR comment

fed4579

Clippy

f8878c6

Update snapshots

fcbb760

alexkirsz force-pushed the alexkirsz/web-866-fspath-extensions branch from 74ada12 to fcbb760 Compare July 3, 2023 13:25

vercel bot deployed to Preview – turbo-site July 3, 2023 13:26 View deployment

alexkirsz merged commit d68dd5d into main Jul 3, 2023

alexkirsz deleted the alexkirsz/web-866-fspath-extensions branch July 3, 2023 13:38

alexkirsz mentioned this pull request Jul 3, 2023

Misc. changes to support App Router build #5448

Merged

sokra mentioned this pull request Jul 4, 2023

update turbopack vercel/next.js#52186

Merged

kodiakhq bot pushed a commit to vercel/next.js that referenced this pull request Jul 4, 2023

update turbopack (#52186)

532f779

* vercel/turborepo#5395 * vercel/turborepo#5452

shuding pushed a commit to vercel/next.js that referenced this pull request Jul 8, 2023

update turbopack (#52186)

cdef987

* vercel/turborepo#5395 * vercel/turborepo#5452

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New FileSystemPath methods: with_extension and file_stem #5395

New FileSystemPath methods: with_extension and file_stem #5395

alexkirsz commented Jun 27, 2023

vercel bot commented Jun 27, 2023 •

edited

Loading

alexkirsz commented Jun 27, 2023 •

edited

Loading

github-actions bot commented Jun 27, 2023 •

edited

Loading

github-actions bot commented Jun 27, 2023 •

edited

Loading

github-actions bot commented Jun 27, 2023

github-actions bot commented Jun 27, 2023

jridgewell left a comment

github-actions bot commented Jun 28, 2023

github-actions bot commented Jun 28, 2023

github-actions bot commented Jul 3, 2023

github-actions bot commented Jul 3, 2023

github-actions bot commented Jul 3, 2023

github-actions bot commented Jul 3, 2023

github-actions bot commented Jul 3, 2023

github-actions bot commented Jul 3, 2023

New FileSystemPath methods: with_extension and file_stem #5395

New FileSystemPath methods: with_extension and file_stem #5395

Conversation

alexkirsz commented Jun 27, 2023

Description

Testing Instructions

vercel bot commented Jun 27, 2023 • edited Loading

alexkirsz commented Jun 27, 2023 • edited Loading

github-actions bot commented Jun 27, 2023 • edited Loading

github-actions bot commented Jun 27, 2023 • edited Loading

🟢 CI successful 🟢

github-actions bot commented Jun 27, 2023

Linux Benchmark for 8b98e2b

github-actions bot commented Jun 27, 2023

MacOS Benchmark for 8b98e2b

jridgewell left a comment

Choose a reason for hiding this comment

github-actions bot commented Jun 28, 2023

Linux Benchmark for c8391e7

github-actions bot commented Jun 28, 2023

Windows Benchmark for c8391e7

github-actions bot commented Jul 3, 2023

Linux Benchmark for 9dc695a

github-actions bot commented Jul 3, 2023

MacOS Benchmark for 9dc695a

github-actions bot commented Jul 3, 2023

Linux Benchmark for 3954c0e

github-actions bot commented Jul 3, 2023

Linux Benchmark for 45c662f

github-actions bot commented Jul 3, 2023

Windows Benchmark for 45c662f

github-actions bot commented Jul 3, 2023

MacOS Benchmark for 45c662f

vercel bot commented Jun 27, 2023 •

edited

Loading

alexkirsz commented Jun 27, 2023 •

edited

Loading

github-actions bot commented Jun 27, 2023 •

edited

Loading

github-actions bot commented Jun 27, 2023 •

edited

Loading

Linux Benchmark for `8b98e2b`

MacOS Benchmark for `8b98e2b`

Linux Benchmark for `c8391e7`

Windows Benchmark for `c8391e7`

Linux Benchmark for `9dc695a`

MacOS Benchmark for `9dc695a`

Linux Benchmark for `3954c0e`