fix node.js externals #6530
Merged
fix node.js externals #6530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Ignored Deployments
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
|
✅ This change can build |
|
Linux Benchmark for 0b8b6edClick to view benchmark
|
Linux Benchmark for 163154aClick to view benchmark
|
Linux Benchmark for acde138Click to view benchmark
|
Linux Benchmark for ac3de8a
Click to view full benchmark
|
kwonoj
approved these changes
Nov 21, 2023
| @@ -1,10 +1,11 @@ | |||
| //! TODO(WEB-741) Remove this file once Sass is supported. | |||
There was a problem hiding this comment.
just nit but I guess this can be actually removed? prolly not for this pr.
wbinnssmith
pushed a commit
to vercel/next.js
that referenced
this pull request
Nov 21, 2023
### What? Various fixes in handling of externals in node.js * add extensions to builtin externals to allow node.js ESM to work * improve the auto-externals logic to detect more edge cases * prepare for `esmExternals` support, but that's blocked by client manifest missing the async flag * currently only `esmExternals: false` is supported ### Why? ### Turbopack Changes * vercel/turborepo#6531 <!-- Leah - fix(turbopack): postcss should be applied to `@import`ed CSS files --> * vercel/turborepo#6530 <!-- Tobias Koppers - fix node.js externals --> --------- Co-authored-by: Leah <github.leah@hrmny.sh> Co-authored-by: Zack Tanner <zacktanner@gmail.com>
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
### Description * Extend resolving to allow reference type for plugins * add extensions for MainField * add an option `import_externals` to context to specify externals behavior for ESM imports * false: require() is used * true: import() is used and the module becomes an async module * adds `import_externals: false` support for dynamic import * adds `import_externals: true` support for normal import see also #58129 ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> Closes PACK-2011
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description * Extend resolving to allow reference type for plugins * add extensions for MainField * add an option `import_externals` to context to specify externals behavior for ESM imports * false: require() is used * true: import() is used and the module becomes an async module * adds `import_externals: false` support for dynamic import * adds `import_externals: true` support for normal import see also #58129 ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> Closes PACK-2011
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description * Extend resolving to allow reference type for plugins * add extensions for MainField * add an option `import_externals` to context to specify externals behavior for ESM imports * false: require() is used * true: import() is used and the module becomes an async module * adds `import_externals: false` support for dynamic import * adds `import_externals: true` support for normal import see also #58129 ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> Closes PACK-2011
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
### Description * Extend resolving to allow reference type for plugins * add extensions for MainField * add an option `import_externals` to context to specify externals behavior for ESM imports * false: require() is used * true: import() is used and the module becomes an async module * adds `import_externals: false` support for dynamic import * adds `import_externals: true` support for normal import see also #58129 ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> Closes PACK-2011
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
import_externalsto context to specify externals behavior for ESM importsimport_externals: falsesupport for dynamic importimport_externals: truesupport for normal importsee also vercel/next.js#58129
Testing Instructions
Closes PACK-2011