fix(turbopack): postcss should be applied to @imported CSS files
#6531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
9 Ignored Deployments
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
🟢 CI successful 🟢Thanks |
|
✅ This change can build |
sokra
approved these changes
Nov 21, 2023
sokra
reviewed
Nov 21, 2023
ForsakenHarmony
force-pushed
the
hrmny/pack-1992-postcss-at-imported-css-files
branch
from
cfe8925 to
cc17f60
Compare
ForsakenHarmony
deleted the
hrmny/pack-1992-postcss-at-imported-css-files
branch
Linux Benchmark for 3744734
Click to view full benchmark
|
wbinnssmith
pushed a commit
to vercel/next.js
that referenced
this pull request
Nov 21, 2023
### What? Various fixes in handling of externals in node.js * add extensions to builtin externals to allow node.js ESM to work * improve the auto-externals logic to detect more edge cases * prepare for `esmExternals` support, but that's blocked by client manifest missing the async flag * currently only `esmExternals: false` is supported ### Why? ### Turbopack Changes * vercel/turborepo#6531 <!-- Leah - fix(turbopack): postcss should be applied to `@import`ed CSS files --> * vercel/turborepo#6530 <!-- Tobias Koppers - fix node.js externals --> --------- Co-authored-by: Leah <github.leah@hrmny.sh> Co-authored-by: Zack Tanner <zacktanner@gmail.com>
ForsakenHarmony
added a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
ForsakenHarmony
added a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
ForsakenHarmony
added a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
ForsakenHarmony
added a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously we only applied postcss to CSS files (not CSS modules) that were imported from javascript.
This PR makes sure the source transform gets applied to all CSS files.