Make EcmascriptDevChunkContent public to other crates
#7160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed to read source map data to trace sourcemaps in Next.js
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Ignored Deployments
|
wbinnssmith
added a commit
to vercel/next.js
that referenced
this pull request
Jan 30, 2024
Requires vercel/turborepo#7160 Previously, we attempted to trace stacks through the source map for the entire chunk rather than the map for the chunk update. Test Plan: Now passing event handler error test in `acceptance-app/error-recovery.ts`
🟢 Turbopack Benchmark CI successful 🟢Thanks |
|
✅ This change can build |
|
kdy1
approved these changes
Jan 30, 2024
sokra
approved these changes
Jan 30, 2024
sokra
pushed a commit
to vercel/next.js
that referenced
this pull request
Jan 30, 2024
# Turbopack changes * vercel/turborepo#7160 <!-- Will Binns-Smith - Make `EcmascriptDevChunkContent` public to other crates --> * vercel/turborepo#7162 <!-- Tim Neutkens - Fix sourcemap PR compile error --> * vercel/turborepo#7163 <!-- Donny/강동윤 - fix: Revert `preset-env` mode of `styled-jsx` in turbopack --> ### What? Update turbopack ### Why? To apply vercel/turborepo#7163 ### How? Closes PACK-2323
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
…repo#7160) This is needed to read source map data to trace sourcemaps in Next.js Closes PACK-2317
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
…repo#7160) This is needed to read source map data to trace sourcemaps in Next.js Closes PACK-2317
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
…repo#7160) This is needed to read source map data to trace sourcemaps in Next.js Closes PACK-2317
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
…repo#7160) This is needed to read source map data to trace sourcemaps in Next.js Closes PACK-2317
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to read source map data to trace sourcemaps in Next.js
Closes PACK-2317