Fix sourcemap PR compile error #7162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Ignored Deployments
|
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @timneutkens and the rest of your teammates on |
🟢 Turbopack Benchmark CI successful 🟢Thanks |
|
✅ This change can build |
|
sokra
approved these changes
Jan 30, 2024
sokra
pushed a commit
to vercel/next.js
that referenced
this pull request
Jan 30, 2024
# Turbopack changes * vercel/turborepo#7160 <!-- Will Binns-Smith - Make `EcmascriptDevChunkContent` public to other crates --> * vercel/turborepo#7162 <!-- Tim Neutkens - Fix sourcemap PR compile error --> * vercel/turborepo#7163 <!-- Donny/강동윤 - fix: Revert `preset-env` mode of `styled-jsx` in turbopack --> ### What? Update turbopack ### Why? To apply vercel/turborepo#7163 ### How? Closes PACK-2323
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
### Description Fixes the error on #61369 Test run: https://github.com/vercel/turbo/blob/7799d37728ae34be5f3aedd227c955067e16c274/crates/turbopack-dev/src/ecmascript/content_entry.rs#L44 Excerpt: ``` error: type `turbopack_binding::turbopack::turbopack_dev::ecmascript::content_entry::EcmascriptDevChunkContentEntries` is private --> packages/next-swc/crates/napi/src/next_api/project.rs:856:35 | 856 | let entries = content.entries().await?; | ^^^^^^^^^^^^^^^^^^^^^^^^ private type error: type `turbopack_binding::turbopack::turbopack_dev::ecmascript::content_entry::EcmascriptDevChunkContentEntry` is private --> packages/next-swc/crates/napi/src/next_api/project.rs:857:33 | 857 | let entry = entries.get(&ModuleId::String(module).cell().await?); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ private type error: type `turbopack_binding::turbopack::turbopack_dev::ecmascript::content_entry::EcmascriptDevChunkContentEntry` is private --> packages/next-swc/crates/napi/src/next_api/project.rs:858:37 | 858 | let map = match entry { | ^^^^^ private type error: could not compile `next-swc-napi` (lib) due to 3 previous errors ``` <!-- ✍️ Write a short summary of your work. If necessary, include relevant screenshots. --> ### Testing Instructions <!-- Give a quick description of steps to test your changes. -->
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description Fixes the error on #61369 Test run: https://github.com/vercel/turbo/blob/d14febb4f93d20bb21fb821a2326ed7339163b0d/crates/turbopack-dev/src/ecmascript/content_entry.rs#L44 Excerpt: ``` error: type `turbopack_binding::turbopack::turbopack_dev::ecmascript::content_entry::EcmascriptDevChunkContentEntries` is private --> packages/next-swc/crates/napi/src/next_api/project.rs:856:35 | 856 | let entries = content.entries().await?; | ^^^^^^^^^^^^^^^^^^^^^^^^ private type error: type `turbopack_binding::turbopack::turbopack_dev::ecmascript::content_entry::EcmascriptDevChunkContentEntry` is private --> packages/next-swc/crates/napi/src/next_api/project.rs:857:33 | 857 | let entry = entries.get(&ModuleId::String(module).cell().await?); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ private type error: type `turbopack_binding::turbopack::turbopack_dev::ecmascript::content_entry::EcmascriptDevChunkContentEntry` is private --> packages/next-swc/crates/napi/src/next_api/project.rs:858:37 | 858 | let map = match entry { | ^^^^^ private type error: could not compile `next-swc-napi` (lib) due to 3 previous errors ``` <!-- ✍️ Write a short summary of your work. If necessary, include relevant screenshots. --> ### Testing Instructions <!-- Give a quick description of steps to test your changes. -->
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description Fixes the error on #61369 Test run: https://github.com/vercel/turbo/blob/35de4a076ce6642fa502b736f101a91e3386e5f9/crates/turbopack-dev/src/ecmascript/content_entry.rs#L44 Excerpt: ``` error: type `turbopack_binding::turbopack::turbopack_dev::ecmascript::content_entry::EcmascriptDevChunkContentEntries` is private --> packages/next-swc/crates/napi/src/next_api/project.rs:856:35 | 856 | let entries = content.entries().await?; | ^^^^^^^^^^^^^^^^^^^^^^^^ private type error: type `turbopack_binding::turbopack::turbopack_dev::ecmascript::content_entry::EcmascriptDevChunkContentEntry` is private --> packages/next-swc/crates/napi/src/next_api/project.rs:857:33 | 857 | let entry = entries.get(&ModuleId::String(module).cell().await?); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ private type error: type `turbopack_binding::turbopack::turbopack_dev::ecmascript::content_entry::EcmascriptDevChunkContentEntry` is private --> packages/next-swc/crates/napi/src/next_api/project.rs:858:37 | 858 | let map = match entry { | ^^^^^ private type error: could not compile `next-swc-napi` (lib) due to 3 previous errors ``` <!-- ✍️ Write a short summary of your work. If necessary, include relevant screenshots. --> ### Testing Instructions <!-- Give a quick description of steps to test your changes. -->
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
### Description Fixes the error on #61369 Test run: https://github.com/vercel/turbo/blob/8891f6b758d459dd030d40d76dc9c8c16f3966db/crates/turbopack-dev/src/ecmascript/content_entry.rs#L44 Excerpt: ``` error: type `turbopack_binding::turbopack::turbopack_dev::ecmascript::content_entry::EcmascriptDevChunkContentEntries` is private --> packages/next-swc/crates/napi/src/next_api/project.rs:856:35 | 856 | let entries = content.entries().await?; | ^^^^^^^^^^^^^^^^^^^^^^^^ private type error: type `turbopack_binding::turbopack::turbopack_dev::ecmascript::content_entry::EcmascriptDevChunkContentEntry` is private --> packages/next-swc/crates/napi/src/next_api/project.rs:857:33 | 857 | let entry = entries.get(&ModuleId::String(module).cell().await?); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ private type error: type `turbopack_binding::turbopack::turbopack_dev::ecmascript::content_entry::EcmascriptDevChunkContentEntry` is private --> packages/next-swc/crates/napi/src/next_api/project.rs:858:37 | 858 | let map = match entry { | ^^^^^ private type error: could not compile `next-swc-napi` (lib) due to 3 previous errors ``` <!-- ✍️ Write a short summary of your work. If necessary, include relevant screenshots. --> ### Testing Instructions <!-- Give a quick description of steps to test your changes. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the error on vercel/next.js#61369
Test run: https://github.com/vercel/turbo/blob/08e09624524425db1530381941d1fedbed27fe4f/crates/turbopack-dev/src/ecmascript/content_entry.rs#L44
Excerpt:
Testing Instructions