ci: update upload-artifact and download-artifact actions to v4
#9447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v3 of `actions/upload-artifact` and `actions/download-artifact` will be fully deprecated by 5 December 2024. Jobs that are scheduled to run during the brownout periods will also fail. See [1][2]. [1]: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/ [2]: https://github.blog/changelog/2024-11-05-notice-of-breaking-changes-for-github-actions/ Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
turbo-orchestrator
bot
added
area: ci
needs: triage
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Skipped Deployments
|
|
@Juneezee is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
Juneezee
commented
Nov 15, 2024
| name: profiles # This name will be the folder each file gets downloaded to | ||
| name: profiles-${{ matrix.os.name }} # This name will be the folder each file gets downloaded to |
There was a problem hiding this comment.
v4 of actions/upload-artifact does not allow uploading to the same artifact name anymore and we need to give each artifact a unique name. See:
- https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md#multiple-uploads-to-the-same-named-artifact
- https://github.com/actions/upload-artifact?tab=readme-ov-file#not-uploading-to-the-same-artifact
This is the only workflow where we didn't give the artifact a unique name in matrix scenarios.
Comment on lines
-117
to
+119
| name: profiles | ||
| path: packages/turbo-benchmark/profiles/ | ||
| pattern: profiles-* | ||
| merge-multiple: true |
There was a problem hiding this comment.
Following the migration guide https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md#multiple-uploads-to-the-same-named-artifact
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
chris-olszewski
added a commit
that referenced
this pull request
Nov 19, 2024
### Description #9447 bumped us to `upload-artifact` to v4 which uses Node 20. Node 20 required a newer glibc version than was available on our build that targeted AWS's Lambda2's glibc version. See [this job](https://github.com/vercel/turborepo/actions/runs/11897321603/job/33151832964#step:12:21) for an example failure. Requiring this glibc version isn't necessary for the musl builds since it uses musl instead of glibc for libc. I do not think this was intentional to have the musl binary building in this container as we changed this back when we were cross compiling: 8ca67c3 Future work: This does not fix the `@turbo/repository` release. ### Testing Instructions Ran test release and x86 msul build now passes: [job](https://github.com/vercel/turborepo/actions/runs/11917567457/job/33214049836)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
v3 of
actions/upload-artifactandactions/download-artifactwill be fully deprecated by 5 December 2024. Jobs that are scheduled to run during the brownout periods will also fail. See:Testing Instructions
Run the CI jobs