ci: update upload-artifact and download-artifact actions to v4
#9447
+17
−15
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -87,9 +87,9 @@ jobs: | |
| run: pnpm -F @turbo/benchmark ttft "${{ steps.filename.outputs.filename }}" | ||
|
|
||
| - name: Upload Artifacts | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: profiles-${{ matrix.os.name }} # This name will be the folder each file gets downloaded to | ||
| if-no-files-found: error | ||
| # cwd is root of the repository, so we need the benchmark/ prefixed path | ||
| path: | | ||
|
|
@@ -112,10 +112,11 @@ jobs: | |
| uses: ./.github/actions/setup-node | ||
|
|
||
| - name: Download profiles | ||
| uses: actions/download-artifact@v4 | ||
| with: | ||
| path: packages/turbo-benchmark/profiles/ | ||
| pattern: profiles-* | ||
| merge-multiple: true | ||
|
Comment on lines
-117
to
+119
There was a problem hiding this comment. Following the migration guide https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md#multiple-uploads-to-the-same-named-artifact |
||
|
|
||
| - name: Display TTFT Data | ||
| shell: bash | ||
|
|
@@ -146,10 +147,11 @@ jobs: | |
| uses: ./.github/actions/setup-node | ||
|
|
||
| - name: Download profiles | ||
| uses: actions/download-artifact@v4 | ||
| with: | ||
| path: packages/turbo-benchmark/profiles/ | ||
| pattern: profiles-* | ||
| merge-multiple: true | ||
|
|
||
| - name: Display TTFT Data | ||
| shell: bash | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v4 of
actions/upload-artifactdoes not allow uploading to the same artifact name anymore and we need to give each artifact a unique name. See:This is the only workflow where we didn't give the artifact a unique name in matrix scenarios.