Fixes in github actions for clang-tidy and clang-format #611
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #611 +/- ##
=======================================
Coverage 93.73% 93.73%
=======================================
Files 41 41
Lines 5939 5939
=======================================
Hits 5567 5567
Misses 372 372 |
|
|
||
| CheckOptions: | ||
| - key: readability-identifier-naming.ClassCase | ||
| value: CamelCase | ||
| value: aNy_CasE |
There was a problem hiding this comment.
Changed this because clad::array and clad::matrix are small cases but Visitors are capital cases.
.clang-tidy
Outdated
| @@ -26,14 +26,15 @@ Checks: > | |||
| -readability-magic-numbers, | |||
| -readability-named-parameter, | |||
| -readability-function-cognitive-complexity, | |||
| -cppcoreguidelines-pro-bounds-pointer-arithmetic, | |||
There was a problem hiding this comment.
Removed this check because clad::array deals with pointer arithmetic
There was a problem hiding this comment.
Can we disable that check if a comment in that particular file?
There was a problem hiding this comment.
I don't think so; there is a similar discussion here: isocpp/CppCoreGuidelines#862 for implementing a vector-like container.
There was a problem hiding this comment.
How about using that approach: https://clang.llvm.org/extra/clang-tidy/#suppressing-undesired-diagnostics
There was a problem hiding this comment.
Yup, it worked. I had no idea about this 😅
No description provided.