Simplify derivative statements in VisitBinaryOperator #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PetroZarytskyi
changed the title
|
clang-tidy review says "All clean, LGTM! 👍" |
PetroZarytskyi
force-pushed
the
optimize-dfdx
branch
from
7b57f7c
to
362a814
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #690 +/- ##
==========================================
+ Coverage 94.37% 94.46% +0.08%
==========================================
Files 48 48
Lines 7062 7066 +4
==========================================
+ Hits 6665 6675 +10
+ Misses 397 391 -6
|
PetroZarytskyi
force-pushed
the
optimize-dfdx
branch
from
362a814
to
d519797
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
PetroZarytskyi
force-pushed
the
optimize-dfdx
branch
from
d519797
to
19db17d
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
vgvassilev
reviewed
Dec 27, 2023
| Ldiff = Visit(L, dl); | ||
| StmtDiff LStored = Ldiff; | ||
| if (utils::ContainsFunctionCalls(LStored.getExpr()) || LStored.getExpr()->HasSideEffects(m_Context)) |
There was a problem hiding this comment.
Can we move these checks into UsefulToStore? I believe there is even a fixme there.
PetroZarytskyi
force-pushed
the
optimize-dfdx
branch
from
879a019
to
2f6bfa8
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
PetroZarytskyi
force-pushed
the
optimize-dfdx
branch
from
2f6bfa8
to
86e57c8
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
PetroZarytskyi
force-pushed
the
optimize-dfdx
branch
from
86e57c8
to
63d9290
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
vgvassilev
reviewed
Dec 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every time we visit multiplication or division in the reverse mode, we store expressions for the derivatives of the LHS and the RHS.
This makes the derivative code less readable and often produces unused variables. For instance, this code
will be differentiated as
while could be just