Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for increment operator in return statement #707

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

vaithak
Copy link
Collaborator

@vaithak vaithak commented Jan 11, 2024

Closes #687

@vaithak
Copy link
Collaborator Author

vaithak commented Jan 11, 2024

#687 was fixed in #690, adding the test here to ensure it doesn't arise in future. If this is not required, we can anyway close #687.

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3a5ad4a) 94.54% compared to head (55718ce) 94.54%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #707   +/-   ##
=======================================
  Coverage   94.54%   94.54%           
=======================================
  Files          49       49           
  Lines        7183     7183           
=======================================
  Hits         6791     6791           
  Misses        392      392           

Copy link
Owner

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vgvassilev vgvassilev merged commit 40d8bec into master Jan 11, 2024
78 checks passed
@vaithak vaithak deleted the increment-return branch March 13, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong outputs in reverse mode with unary operators in return statements
2 participants