[clang] Add clang 18 support #824

mcbarton · 2024-03-15T19:47:12Z

This PR will add support for clang 18
Fixes #805

codecov · 2024-03-15T20:13:34Z

Codecov Report

Attention: Patch coverage is 83.58209% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 94.77%. Comparing base (5b66f0e) to head (44a7a44).

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #824      +/-   ##
==========================================
- Coverage   94.82%   94.77%   -0.06%     
==========================================
  Files          49       49              
  Lines        7501     7499       -2     
==========================================
- Hits         7113     7107       -6     
- Misses        388      392       +4

Files	Coverage Δ
include/clad/Differentiator/StmtClone.h	`77.77% <ø> (ø)`
include/clad/Differentiator/VisitorBase.h	`100.00% <100.00%> (ø)`
lib/Differentiator/BaseForwardModeVisitor.cpp	`99.06% <100.00%> (ø)`
lib/Differentiator/CladUtils.cpp	`92.98% <100.00%> (-0.02%)`	⬇️
lib/Differentiator/DiffPlanner.cpp	`98.59% <100.00%> (+0.01%)`	⬆️
lib/Differentiator/HessianModeVisitor.cpp	`99.45% <100.00%> (-0.01%)`	⬇️
lib/Differentiator/ReverseModeForwPassVisitor.cpp	`100.00% <100.00%> (ø)`
lib/Differentiator/ReverseModeVisitor.cpp	`97.21% <100.00%> (+<0.01%)`	⬆️
lib/Differentiator/VisitorBase.cpp	`95.95% <100.00%> (+<0.01%)`	⬆️
tools/ClangPlugin.cpp	`96.51% <100.00%> (ø)`
... and 2 more

Files	Coverage Δ
include/clad/Differentiator/StmtClone.h	`77.77% <ø> (ø)`
include/clad/Differentiator/VisitorBase.h	`100.00% <100.00%> (ø)`
lib/Differentiator/BaseForwardModeVisitor.cpp	`99.06% <100.00%> (ø)`
lib/Differentiator/CladUtils.cpp	`92.98% <100.00%> (-0.02%)`	⬇️
lib/Differentiator/DiffPlanner.cpp	`98.59% <100.00%> (+0.01%)`	⬆️
lib/Differentiator/HessianModeVisitor.cpp	`99.45% <100.00%> (-0.01%)`	⬇️
lib/Differentiator/ReverseModeForwPassVisitor.cpp	`100.00% <100.00%> (ø)`
lib/Differentiator/ReverseModeVisitor.cpp	`97.21% <100.00%> (+<0.01%)`	⬆️
lib/Differentiator/VisitorBase.cpp	`95.95% <100.00%> (+<0.01%)`	⬆️
tools/ClangPlugin.cpp	`96.51% <100.00%> (ø)`
... and 2 more

github-actions

clang-tidy made some suggestions

include/clad/Differentiator/Compatibility.h

github-actions

clang-tidy made some suggestions

github-actions · 2024-03-18T21:27:13Z

include/clad/Differentiator/Compatibility.h

-   return Ctx.getConstantArrayType(EltTy, ArySize, SizeExpr, ASM, IndexTypeQuals);
+// clang 18 clang::ArrayType::ArraySizeModifier became clang::ArraySizeModifier
+#if CLANG_VERSION_MAJOR < 18
+   static inline QualType getConstantArrayType(const ASTContext &Ctx,


warning: unused function 'getConstantArrayType' [clang-diagnostic-unused-function]

static inline QualType getConstantArrayType(const ASTContext &Ctx, ^

github-actions

clang-tidy made some suggestions

lib/Differentiator/StmtClone.cpp

CMakeLists.txt

lib/Differentiator/CladUtils.cpp

lib/Differentiator/HessianModeVisitor.cpp

tools/ClangPlugin.cpp

lib/Differentiator/StmtClone.cpp

mcbarton · 2024-03-24T18:57:36Z

@vgvassilev It is now building clad with clang-18 but it doesn't pass all the tests. It says that it is expected that 2 will fail, but 5 tests fail. Which 2 are expected to fail?

include/clad/Differentiator/Compatibility.h

include/clad/Differentiator/StmtClone.h

include/clad/Differentiator/VisitorBase.h

lib/Differentiator/CladUtils.cpp

lib/Differentiator/HessianModeVisitor.cpp

lib/Differentiator/StmtClone.cpp

lib/Differentiator/VisitorBase.cpp

alexander-penev

I made some comments about Compatibility.h. It is good that some changes are made before we accept this PR.

include/clad/Differentiator/Compatibility.h

tools/ClangPlugin.cpp

github-actions

clang-tidy made some suggestions

github-actions · 2024-03-31T07:43:09Z

include/clad/Differentiator/Compatibility.h

+//Clang 18 ArrayType::Normal -> ArraySizeModifier::Normal
+
+#if LLVM_VERSION_MAJOR < 18
+const auto ArraySizeModifier_Normal = ArrayType::Normal;


warning: reference to 'ArrayType' is ambiguous [clang-diagnostic-error]

const auto ArraySizeModifier_Normal = clang::ArrayType::Normal; ^

Additional context

llvm/include/clang/Sema/Sema.h:86: candidate found by name lookup is 'clang::ArrayType'

class ArrayType; ^

llvm/include/llvm/Frontend/OpenMP/OMPConstants.h:24: candidate found by name lookup is 'llvm::ArrayType'

class ArrayType; ^

github-actions · 2024-03-31T07:43:09Z

include/clad/Differentiator/Compatibility.h

+//Clang 18 ETK_None -> ElaboratedTypeKeyword::None
+
+#if LLVM_VERSION_MAJOR < 18
+const auto ElaboratedTypeKeyword_None ETK_None;


warning: declaration of variable 'ElaboratedTypeKeyword_None' with deduced type 'const auto' requires an initializer [clang-diagnostic-error]

const auto ElaboratedTypeKeyword_None = ETK_None; ^

github-actions · 2024-03-31T07:43:09Z

include/clad/Differentiator/Compatibility.h

+//Clang 18 ETK_None -> ElaboratedTypeKeyword::None
+
+#if LLVM_VERSION_MAJOR < 18
+const auto ElaboratedTypeKeyword_None ETK_None;


warning: expected ';' after top level declarator [clang-diagnostic-error]

Suggested change

const auto ElaboratedTypeKeyword_None ETK_None;

const auto ElaboratedTypeKeyword_None = ETK_None;

github-actions · 2024-03-31T07:43:09Z

lib/Differentiator/CladUtils.cpp

@@ -166,7 +166,7 @@ namespace clad {
        utils::BuildNNS(semaRef, const_cast<clang::DeclContext*>(declContext), CSS);
        NestedNameSpecifier* NS = CSS.getScopeRep();
        if (auto* Prefix = NS->getPrefix())
-          return C.getElaboratedType(ETK_None, Prefix, QT);
+            return C.getElaboratedType(ElaboratedTypeKeyword_None, Prefix, QT);


warning: use of undeclared identifier 'ElaboratedTypeKeyword_None' [clang-diagnostic-error]

return C.getElaboratedType(clad_compat::ElaboratedTypeKeyword_None, Prefix, QT); ^

github-actions · 2024-03-31T07:43:09Z

lib/Differentiator/CladUtils.cpp

@@ -273,7 +273,7 @@
                                                    llvm::APInt(/*numBits=*/32,
                                                                str.size() + 1),
                                                    /*SizeExpr=*/nullptr,
-                                                    /*ASM=*/ArrayType::Normal,
+                                                    /*ASM=*/ArrayType_Normal,


warning: use of undeclared identifier 'ArrayType_Normal' [clang-diagnostic-error]

/*ASM=*/clad_compat::ArraySizeModifier_Normal, ^

github-actions · 2024-03-31T07:43:09Z

lib/Differentiator/CladUtils.cpp

@@ -273,7 +273,7 @@
                                                    llvm::APInt(/*numBits=*/32,
                                                                str.size() + 1),
                                                    /*SizeExpr=*/nullptr,
-                                                    /*ASM=*/ArrayType::Normal,
+                                                    /*ASM=*/ArrayType_Normal,
                                                    /*IndexTypeQuals*/ 0);
      StringLiteral* SL = StringLiteral::Create(C, str,
                                                /*Kind=*/clad_compat::StringKind_Ordinary,


warning: no member named 'StringKind_Ordinary' in namespace 'clad_compat' [clang-diagnostic-error]

/*Kind=*/clad_compat::StringLiteralKind_Ordinary, ^

github-actions · 2024-03-31T07:43:09Z

lib/Differentiator/HessianModeVisitor.cpp

@@ -41,7 +41,7 @@ namespace clad {
                                          llvm::APInt(/*numBits=*/32,
                                                      str.size() + 1),
                                          /*SizeExpr=*/nullptr,
-                                          /*ASM=*/ArrayType::Normal,
+                                          /*ASM=*/ArrayType_Normal,


warning: use of undeclared identifier 'ArrayType_Normal' [clang-diagnostic-error]

/*ASM=*/clad_compat::ArraySizeModifier_Normal, ^

github-actions · 2024-03-31T07:43:09Z

lib/Differentiator/HessianModeVisitor.cpp

@@ -41,7 +41,7 @@
                                          llvm::APInt(/*numBits=*/32,
                                                      str.size() + 1),
                                          /*SizeExpr=*/nullptr,
-                                          /*ASM=*/ArrayType::Normal,
+                                          /*ASM=*/ArrayType_Normal,
                                          /*IndexTypeQuals*/ 0);
    const StringLiteral* SL =
        StringLiteral::Create(C, str, /*Kind=*/clad_compat::StringKind_Ordinary,


warning: no member named 'StringKind_Ordinary' in namespace 'clad_compat' [clang-diagnostic-error]

StringLiteral::Create(C, str, /*Kind=*/clad_compat::StringLiteralKind_Ordinary, ^

github-actions · 2024-03-31T07:43:09Z

lib/Differentiator/VisitorBase.cpp

@@ -452,7 +452,7 @@ namespace clad {

    // Create elaborated type with namespace specifier,
    // i.e. class<T> -> clad::class<T>
-    return m_Context.getElaboratedType(ETK_None, NS, TT);
+      return m_Context.getElaboratedType(ElaboratedTypeKeyword_None, NS, TT);


warning: use of undeclared identifier 'ElaboratedTypeKeyword_None' [clang-diagnostic-error]

return m_Context.getElaboratedType(clad_compat::ElaboratedTypeKeyword_None, NS, TT); ^

github-actions

clang-tidy made some suggestions

github-actions · 2024-03-31T14:47:07Z

lib/Differentiator/CladUtils.cpp

@@ -166,7 +166,7 @@ namespace clad {
        utils::BuildNNS(semaRef, const_cast<clang::DeclContext*>(declContext), CSS);
        NestedNameSpecifier* NS = CSS.getScopeRep();
        if (auto* Prefix = NS->getPrefix())
-          return C.getElaboratedType(ETK_None, Prefix, QT);
+            return C.getElaboratedType(ElaboratedTypeKeyword_None, Prefix, QT);


warning: use of undeclared identifier 'ElaboratedTypeKeyword_None'; did you mean 'clad_compat::ElaboratedTypeKeyword_None'? [clang-diagnostic-error]

Suggested change

return C.getElaboratedType(ElaboratedTypeKeyword_None, Prefix, QT);

return C.getElaboratedType(clad_compat::ElaboratedTypeKeyword_None, Prefix, QT);

Additional context

include/clad/Differentiator/Compatibility.h:100: 'clad_compat::ElaboratedTypeKeyword_None' declared here

const auto ElaboratedTypeKeyword_None = ETK_None; ^

github-actions · 2024-03-31T14:47:07Z

lib/Differentiator/CladUtils.cpp

@@ -273,7 +273,7 @@
                                                    llvm::APInt(/*numBits=*/32,
                                                                str.size() + 1),
                                                    /*SizeExpr=*/nullptr,
-                                                    /*ASM=*/ArrayType::Normal,
+                                                    /*ASM=*/ArrayType_Normal,


warning: use of undeclared identifier 'ArrayType_Normal' [clang-diagnostic-error]

/*ASM=*/ArrayType_Normal, ^

github-actions · 2024-03-31T14:47:08Z

lib/Differentiator/CladUtils.cpp

@@ -273,7 +273,7 @@
                                                    llvm::APInt(/*numBits=*/32,
                                                                str.size() + 1),
                                                    /*SizeExpr=*/nullptr,
-                                                    /*ASM=*/ArrayType::Normal,
+                                                    /*ASM=*/ArrayType_Normal,
                                                    /*IndexTypeQuals*/ 0);
      StringLiteral* SL = StringLiteral::Create(C, str,
                                                /*Kind=*/clad_compat::StringKind_Ordinary,


warning: no member named 'StringKind_Ordinary' in namespace 'clad_compat' [clang-diagnostic-error]

/*Kind=*/clad_compat::StringKind_Ordinary, ^

github-actions · 2024-03-31T14:47:08Z

lib/Differentiator/HessianModeVisitor.cpp

@@ -41,7 +41,7 @@ namespace clad {
                                          llvm::APInt(/*numBits=*/32,
                                                      str.size() + 1),
                                          /*SizeExpr=*/nullptr,
-                                          /*ASM=*/ArrayType::Normal,
+                                          /*ASM=*/ArrayType_Normal,


warning: use of undeclared identifier 'ArrayType_Normal' [clang-diagnostic-error]

/*ASM=*/ArrayType_Normal, ^

github-actions · 2024-03-31T14:47:08Z

lib/Differentiator/HessianModeVisitor.cpp

@@ -41,7 +41,7 @@
                                          llvm::APInt(/*numBits=*/32,
                                                      str.size() + 1),
                                          /*SizeExpr=*/nullptr,
-                                          /*ASM=*/ArrayType::Normal,
+                                          /*ASM=*/ArrayType_Normal,
                                          /*IndexTypeQuals*/ 0);
    const StringLiteral* SL =
        StringLiteral::Create(C, str, /*Kind=*/clad_compat::StringKind_Ordinary,


warning: no member named 'StringKind_Ordinary' in namespace 'clad_compat' [clang-diagnostic-error]

StringLiteral::Create(C, str, /*Kind=*/clad_compat::StringKind_Ordinary, ^

github-actions · 2024-03-31T14:47:08Z

lib/Differentiator/VisitorBase.cpp

@@ -452,7 +452,7 @@ namespace clad {

    // Create elaborated type with namespace specifier,
    // i.e. class<T> -> clad::class<T>
-    return m_Context.getElaboratedType(ETK_None, NS, TT);
+      return m_Context.getElaboratedType(ElaboratedTypeKeyword_None, NS, TT);


warning: use of undeclared identifier 'ElaboratedTypeKeyword_None'; did you mean 'clad_compat::ElaboratedTypeKeyword_None'? [clang-diagnostic-error]

Suggested change

return m_Context.getElaboratedType(ElaboratedTypeKeyword_None, NS, TT);

return m_Context.getElaboratedType(clad_compat::ElaboratedTypeKeyword_None, NS, TT);

Additional context

include/clad/Differentiator/Compatibility.h:100: 'clad_compat::ElaboratedTypeKeyword_None' declared here

const auto ElaboratedTypeKeyword_None = ETK_None; ^

Co-Authored-By: Vassil Vassilev <v.g.vassilev@gmail.com> Co-Authored-By: Alexander Penev <7923188+alexander-penev@users.noreply.github.com>

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 10 out of 11. Check the log or trigger a new build to see more.

github-actions · 2024-03-31T19:46:45Z

include/clad/Differentiator/Compatibility.h

+#if CLANG_VERSION_MAJOR > 17
+#define CLAD_COMPAT_CLANG17_ActOnLambdaExpr_getCurrentScope_ExtraParam(V) /**/
+#else
+#define CLAD_COMPAT_CLANG17_ActOnLambdaExpr_getCurrentScope_ExtraParam(V)      \


warning: function-like macro 'CLAD_COMPAT_CLANG17_ActOnLambdaExpr_getCurrentScope_ExtraParam' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage]

#define CLAD_COMPAT_CLANG17_ActOnLambdaExpr_getCurrentScope_ExtraParam(V) \ ^

github-actions · 2024-03-31T19:46:45Z

include/clad/Differentiator/Compatibility.h

+// FIXME: Knowndependent set to false temporarily until known value found for
+// initialisation.
+
+static inline Stmt* UnresolvedLookupExpr_Create(


warning: unused function 'UnresolvedLookupExpr_Create' [clang-diagnostic-unused-function]

static inline Stmt* UnresolvedLookupExpr_Create( ^

github-actions · 2024-03-31T19:46:46Z

include/clad/Differentiator/Compatibility.h

+// clang 18 clang::ArrayType::ArraySizeModifier became clang::ArraySizeModifier
+#if CLANG_VERSION_MAJOR < 18
+static inline QualType
+getConstantArrayType(const ASTContext& Ctx, QualType EltTy,


warning: unused function 'getConstantArrayType' [clang-diagnostic-unused-function]

getConstantArrayType(const ASTContext& Ctx, QualType EltTy, ^

github-actions · 2024-03-31T19:46:46Z

lib/Differentiator/StmtClone.cpp

-{                                             \
-  return CLAD_COMPAT_CREATE(CLASS, CTORARGS); \
-}
+#define DEFINE_CLONE_STMT_CO(CLASS, CTORARGS)                                  \


warning: function-like macro 'DEFINE_CLONE_STMT_CO' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage]

#define DEFINE_CLONE_STMT_CO(CLASS, CTORARGS) \ ^

github-actions · 2024-03-31T19:46:46Z

lib/Differentiator/StmtClone.cpp

-  return CLAD_COMPAT_CREATE(CLASS, CTORARGS); \
-}
+#define DEFINE_CLONE_STMT_CO(CLASS, CTORARGS)                                  \
+  Stmt* StmtClone::Visit##CLASS(CLASS* Node) {                                 \


warning: macro replacement list should be enclosed in parentheses [bugprone-macro-parentheses]

Suggested change

Stmt* StmtClone::Visit##CLASS(CLASS* Node) { \

(Stmt* StmtClone::Visit##CLASS(CLASS* Node) { \

lib/Differentiator/StmtClone.cpp:30:

- } + })

github-actions · 2024-03-31T19:46:46Z

lib/Differentiator/StmtClone.cpp

-  return CLAD_COMPAT_CREATE(CLASS, CTORARGS); \
-}
+#define DEFINE_CLONE_STMT_CO(CLASS, CTORARGS)                                  \
+  Stmt* StmtClone::Visit##CLASS(CLASS* Node) {                                 \


warning: macro argument should be enclosed in parentheses [bugprone-macro-parentheses]

Suggested change

Stmt* StmtClone::Visit##CLASS(CLASS* Node) { \

Stmt* StmtClone::Visit##CLASS((CLASS)* Node) { \

github-actions · 2024-03-31T19:46:46Z

lib/Differentiator/StmtClone.cpp

-  clad_compat::ExprSetDeps(result, Node);               \
-  return result;                                        \
-}
+#define DEFINE_CLONE_EXPR_CO(CLASS, CTORARGS)                                  \


warning: function-like macro 'DEFINE_CLONE_EXPR_CO' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage]

#define DEFINE_CLONE_EXPR_CO(CLASS, CTORARGS) \ ^

github-actions · 2024-03-31T19:46:46Z

lib/Differentiator/StmtClone.cpp

-  return result;                                        \
-}
+#define DEFINE_CLONE_EXPR_CO(CLASS, CTORARGS)                                  \
+  Stmt* StmtClone::Visit##CLASS(CLASS* Node) {                                 \


warning: macro replacement list should be enclosed in parentheses [bugprone-macro-parentheses]

Suggested change

Stmt* StmtClone::Visit##CLASS(CLASS* Node) { \

(Stmt* StmtClone::Visit##CLASS(CLASS* Node) { \

lib/Differentiator/StmtClone.cpp:53:

- } + })

github-actions · 2024-03-31T19:46:46Z

lib/Differentiator/StmtClone.cpp

-  return result;                                        \
-}
+#define DEFINE_CLONE_EXPR_CO(CLASS, CTORARGS)                                  \
+  Stmt* StmtClone::Visit##CLASS(CLASS* Node) {                                 \


warning: macro argument should be enclosed in parentheses [bugprone-macro-parentheses]

Suggested change

Stmt* StmtClone::Visit##CLASS(CLASS* Node) { \

Stmt* StmtClone::Visit##CLASS((CLASS)* Node) { \

github-actions · 2024-03-31T19:46:46Z

lib/Differentiator/StmtClone.cpp

-}
+#define DEFINE_CLONE_EXPR_CO(CLASS, CTORARGS)                                  \
+  Stmt* StmtClone::Visit##CLASS(CLASS* Node) {                                 \
+    CLASS* result = (CLASS::Create CTORARGS);                                  \


warning: macro argument should be enclosed in parentheses [bugprone-macro-parentheses]

Suggested change

CLASS* result = (CLASS::Create CTORARGS); \

(CLASS)* result = (CLASS::Create CTORARGS); \

mcbarton · 2024-03-31T19:47:31Z

@vgvassilev @alexander-penev I have addressed your feedback. This PR is ready for further review

github-actions

clang-tidy made some suggestions

github-actions · 2024-03-31T23:06:01Z

lib/Differentiator/StmtClone.cpp

@@ -419,7 +411,8 @@
  return result;
 }

-DEFINE_CLONE_STMT_CO(ReturnStmt, (CLAD_COMPAT_CLANG8_Ctx_ExtraParams Node->getReturnLoc(), Clone(Node->getRetValue()), 0))
+DEFINE_CLONE_STMT_CO(ReturnStmt,
+                     (Ctx, Node->getReturnLoc(), Clone(Node->getRetValue()), 0))


warning: use nullptr [modernize-use-nullptr]

Suggested change

(Ctx, Node->getReturnLoc(), Clone(Node->getRetValue()), 0))

(Ctx, Node->getReturnLoc(), Clone(Node->getRetValue()), nullptr))

github-actions

clang-tidy made some suggestions

github-actions · 2024-04-01T05:48:08Z

include/clad/Differentiator/Compatibility.h

+#if CLANG_VERSION_MAJOR <= 8
+#define CLAD_COMPAT_8_DECLARE_CLONE_FN(ValueStmt) /**/
+#elif CLANG_VERSION_MAJOR > 8
+#define CLAD_COMPAT_8_DECLARE_CLONE_FN(ValueStmt) DECLARE_CLONE_FN(ValueStmt)


warning: function-like macro 'CLAD_COMPAT_8_DECLARE_CLONE_FN' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage]

#define CLAD_COMPAT_8_DECLARE_CLONE_FN(ValueStmt) DECLARE_CLONE_FN(ValueStmt) ^

github-actions · 2024-04-01T05:48:08Z

lib/Differentiator/StmtClone.cpp

-  return result;                                        \
-}
+#define DEFINE_CLONE_EXPR_CO(CLASS, CTORARGS)                                  \
+  Stmt* StmtClone::Visit##CLASS((CLASS)* Node) {                               \


warning: macro replacement list should be enclosed in parentheses [bugprone-macro-parentheses]

Suggested change

Stmt* StmtClone::Visit##CLASS((CLASS)* Node) { \

(Stmt* StmtClone::Visit##CLASS((CLASS)* Node) { \

lib/Differentiator/StmtClone.cpp:53:

- } + })

github-actions · 2024-04-01T05:48:08Z

lib/Differentiator/StmtClone.cpp

@@ -91,8 +88,7 @@
                   (Ctx, Node->getValue(), CloneType(Node->getType()),
                    Node->getLocation()))
 DEFINE_CLONE_EXPR_CO(PredefinedExpr,


warning: expected ';' after top level declarator [clang-diagnostic-error]

DEFINE_CLONE_EXPR_CO(PredefinedExpr, ^

Additional context

lib/Differentiator/StmtClone.cpp:49: expanded from macro 'DEFINE_CLONE_EXPR_CO'

Stmt* StmtClone::Visit##CLASS((CLASS)* Node) { \ ^

github-actions · 2024-04-01T05:48:08Z

lib/Differentiator/StmtClone.cpp

@@ -91,8 +88,7 @@
                   (Ctx, Node->getValue(), CloneType(Node->getType()),
                    Node->getLocation()))
 DEFINE_CLONE_EXPR_CO(PredefinedExpr,


warning: redefinition of 'VisitPredefinedExpr' as different kind of symbol [clang-diagnostic-error]

DEFINE_CLONE_EXPR_CO(PredefinedExpr, ^

expanded from here

github-actions · 2024-04-01T05:48:08Z

lib/Differentiator/StmtClone.cpp

@@ -91,8 +88,7 @@
                   (Ctx, Node->getValue(), CloneType(Node->getType()),
                    Node->getLocation()))
 DEFINE_CLONE_EXPR_CO(PredefinedExpr,


warning: use of undeclared identifier 'Node' [clang-diagnostic-error]

DEFINE_CLONE_EXPR_CO(PredefinedExpr, ^

Additional context

lib/Differentiator/StmtClone.cpp:49: expanded from macro 'DEFINE_CLONE_EXPR_CO'

Stmt* StmtClone::Visit##CLASS((CLASS)* Node) { \ ^

github-actions

clang-tidy made some suggestions

github-actions · 2024-04-01T09:01:50Z

lib/Differentiator/StmtClone.cpp

-  return result;                                        \
-}
+#define DEFINE_CLONE_EXPR_CO(CLASS, CTORARGS)                                  \
+  Stmt* StmtClone::Visit##CLASS(CLASS* Node) {                               \


warning: macro replacement list should be enclosed in parentheses [bugprone-macro-parentheses]

Suggested change

Stmt* StmtClone::Visit##CLASS(CLASS* Node) { \

(Stmt* StmtClone::Visit##CLASS(CLASS* Node) { \

lib/Differentiator/StmtClone.cpp:53:

- } + })

github-actions · 2024-04-01T09:01:50Z

lib/Differentiator/StmtClone.cpp

-  return result;                                        \
-}
+#define DEFINE_CLONE_EXPR_CO(CLASS, CTORARGS)                                  \
+  Stmt* StmtClone::Visit##CLASS(CLASS* Node) {                               \


warning: macro argument should be enclosed in parentheses [bugprone-macro-parentheses]

Suggested change

Stmt* StmtClone::Visit##CLASS(CLASS* Node) { \

Stmt* StmtClone::Visit##CLASS((CLASS)* Node) { \

github-actions · 2024-04-01T09:01:51Z

lib/Differentiator/StmtClone.cpp

-}
+#define DEFINE_CLONE_EXPR_CO(CLASS, CTORARGS)                                  \
+  Stmt* StmtClone::Visit##CLASS(CLASS* Node) {                               \
+    CLASS* result = (CLASS::Create CTORARGS);                                \


warning: macro argument should be enclosed in parentheses [bugprone-macro-parentheses]

Suggested change

CLASS* result = (CLASS::Create CTORARGS); \

(CLASS)* result = (CLASS::Create CTORARGS); \

Fixes vgvassilev#805.

See llvm/llvm-project#87151

vgvassilev · 2024-04-01T10:37:50Z

Thank you @mcbarton and @alexander-penev!

vgvassilev · 2024-04-01T10:38:21Z

The codecov and clang-format complaints are bogus.

vgvassilev requested a review from alexander-penev March 15, 2024 19:49

mcbarton force-pushed the clang-18 branch from e51d29b to d22b78a Compare March 15, 2024 20:07

github-actions bot reviewed Mar 15, 2024

View reviewed changes

include/clad/Differentiator/Compatibility.h Outdated Show resolved Hide resolved

include/clad/Differentiator/Compatibility.h Outdated Show resolved Hide resolved

mcbarton force-pushed the clang-18 branch from d22b78a to 21cf0b5 Compare March 15, 2024 20:16

github-actions bot reviewed Mar 18, 2024

View reviewed changes

github-actions bot reviewed Mar 20, 2024

View reviewed changes

lib/Differentiator/StmtClone.cpp Outdated Show resolved Hide resolved

vgvassilev reviewed Mar 20, 2024

View reviewed changes

CMakeLists.txt Outdated Show resolved Hide resolved

lib/Differentiator/CladUtils.cpp Outdated Show resolved Hide resolved

lib/Differentiator/HessianModeVisitor.cpp Outdated Show resolved Hide resolved

tools/ClangPlugin.cpp Outdated Show resolved Hide resolved

mcbarton commented Mar 20, 2024

View reviewed changes

lib/Differentiator/StmtClone.cpp Outdated Show resolved Hide resolved

vgvassilev reviewed Mar 23, 2024

View reviewed changes

lib/Differentiator/StmtClone.cpp Outdated Show resolved Hide resolved

vgvassilev reviewed Mar 23, 2024

View reviewed changes

lib/Differentiator/StmtClone.cpp Outdated Show resolved Hide resolved

alexander-penev reviewed Mar 26, 2024

View reviewed changes

include/clad/Differentiator/Compatibility.h Outdated Show resolved Hide resolved

alexander-penev reviewed Mar 26, 2024

View reviewed changes

include/clad/Differentiator/Compatibility.h Outdated Show resolved Hide resolved

alexander-penev reviewed Mar 26, 2024

View reviewed changes

include/clad/Differentiator/Compatibility.h Show resolved Hide resolved