Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[clang] Add clang 18 support #824

Merged
merged 4 commits into from
Apr 1, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 20 additions & 5 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,11 @@ jobs:
os: macos-14
compiler: clang
clang-runtime: '17'
#Turn on once clang-18 available through Homebrew
#- name: osx14-arm-clang-runtime18
# os: macos-14
# compiler: clang
# clang-runtime: '18'

- name: osx13-x86-clang-runtime12
os: macos-13
Expand Down Expand Up @@ -78,6 +83,11 @@ jobs:
os: macos-13
compiler: clang
clang-runtime: '17'
#Turn on once clang-18 available through Homebrew
#- name: osx13-x86-clang-runtime18
# os: macos-13
# compiler: clang
# clang-runtime: '18'

- name: win2022-msvc-runtime14
os: windows-2022
Expand All @@ -99,6 +109,11 @@ jobs:
compiler: msvc
clang-runtime: '17'

- name: win2022-msvc-runtime18
os: windows-2022
compiler: msvc
clang-runtime: '18'

- name: ubu22-clang15-runtime16-debug
os: ubuntu-22.04
compiler: clang-15
Expand Down Expand Up @@ -442,12 +457,12 @@ jobs:
extra_packages: 'libtrilinos-kokkos-dev ninja-build'
extra_cmake_options: '-G Ninja'

# Оld, still supported versions
- name: ubu22-clang16-runtime18
os: ubuntu-22.04
compiler: clang-16
clang-runtime: '18'

- name: ubu20-gcc9-runtime7
os: ubuntu-20.04
compiler: gcc-9
clang-runtime: '7'
# Оld, still supported versions

- name: ubu20-gcc9-runtime8
os: ubuntu-20.04
Expand Down
12 changes: 6 additions & 6 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -39,12 +39,12 @@ if( CMAKE_SOURCE_DIR STREQUAL CMAKE_CURRENT_SOURCE_DIR )

## Define clad supported version of clang and llvm

set(CLANG_MIN_SUPPORTED 7.0)
set(CLANG_MAX_SUPPORTED "17.0.x")
set(CLANG_VERSION_UPPER_BOUND 17.1.0)
set(LLVM_MIN_SUPPORTED 7.0)
set(LLVM_MAX_SUPPORTED "17.0.x")
set(LLVM_VERSION_UPPER_BOUND 17.1.0)
set(CLANG_MIN_SUPPORTED 8.0)
set(CLANG_MAX_SUPPORTED "18.1.x")
set(CLANG_VERSION_UPPER_BOUND 18.2.0)
set(LLVM_MIN_SUPPORTED 8.0)
set(LLVM_MAX_SUPPORTED "18.1.x")
set(LLVM_VERSION_UPPER_BOUND 18.2.0)

if (NOT DEFINED Clang_DIR)
set(Clang_DIR ${LLVM_DIR})
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ Clad also provides certain flags to save and print the generated derivative code
- To print the Clad generated derivative: `-Xclang -plugin-arg-clad -Xclang -fdump-derived-fn`

## How to install
At the moment, LLVM/Clang 7.0.x - 17.0.x are supported.
At the moment, LLVM/Clang 8.0.x - 18.1.x are supported.

### Conda Installation

Expand Down Expand Up @@ -276,7 +276,7 @@ make check-clad
```
pip3 install lit
```
Clone the LLVM project and checkout the required LLVM version (Currently supported versions 7.x - 17.x)
Clone the LLVM project and checkout the required LLVM version (Currently supported versions 8.x - 18.x)

```
git clone https://github.com/llvm/llvm-project.git
Expand Down
2 changes: 1 addition & 1 deletion docs/internalDocs/ReleaseNotes.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ described first.
External Dependencies
---------------------

* Clad now works with clang-7 to clang-17
* Clad now works with clang-8 to clang-18


Forward Mode & Reverse Mode
Expand Down
Loading
Loading