Pass the DiffRequest down to the visitors. NFC. #933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgvassilev
requested review from
PetroZarytskyi,
vaithak and
parth-07
and removed request for
PetroZarytskyi
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -99,11 +99,11 @@ namespace clad { | |||
| /// A base class for all common functionality for visitors | |||
| class VisitorBase { | |||
| protected: | |||
| VisitorBase(DerivativeBuilder& builder) | |||
| VisitorBase(DerivativeBuilder& builder, const DiffRequest& request) | |||
There was a problem hiding this comment.
warning: constructor does not initialize these fields: m_Mode [cppcoreguidelines-pro-type-member-init]
VisitorBase(DerivativeBuilder& builder, const DiffRequest& request)
^| /// The function that is currently differentiated. | ||
| const clang::FunctionDecl* m_Function; | ||
| /// The differentiation request that is being currently processed. | ||
| const DiffRequest& m_DiffReq; |
There was a problem hiding this comment.
warning: member 'm_DiffReq' of type 'const DiffRequest &' is a reference [cppcoreguidelines-avoid-const-or-ref-data-members]
const DiffRequest& m_DiffReq;
^| /// The function that is currently differentiated. | ||
| const clang::FunctionDecl* m_Function; | ||
| /// The differentiation request that is being currently processed. | ||
| const DiffRequest& m_DiffReq; |
There was a problem hiding this comment.
warning: member variable 'm_DiffReq' has protected visibility [cppcoreguidelines-non-private-member-variables-in-classes]
const DiffRequest& m_DiffReq;
^| DeclarationNameInfo name(II, validLoc); | ||
| llvm::SaveAndRestore<DeclContext*> SaveContext(m_Sema.CurContext); | ||
| llvm::SaveAndRestore<Scope*> SaveScope(getCurrentScope()); | ||
| DeclContext* DC = const_cast<DeclContext*>(m_Function->getDeclContext()); | ||
| DeclContext* DC = const_cast<DeclContext*>(m_DiffReq->getDeclContext()); |
There was a problem hiding this comment.
warning: do not use const_cast [cppcoreguidelines-pro-type-const-cast]
DeclContext* DC = const_cast<DeclContext*>(m_DiffReq->getDeclContext());
^The intent of this patch is to centralize the information about the diff request in one place. This will help upcoming patches to reduce the state of the visitors and refactor some of the implementation in a common place. That will unblock work on #721.
parth-07
reviewed
Jun 11, 2024
vgvassilev
force-pushed
the
diff-req-nfc
branch
2 times, most recently
from
6bc7d9e
to
97d7051
Compare
This patch avoids picking up the latest uploaded llvm18 and partially mixing it with llvm17.
parth-07
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intent of this patch is to centralize the information about the diff request in one place. This will help upcoming patches to reduce the state of the visitors and refactor some of the implementation in a common place.
That will unblock work on #721.