Refactor duplicate code in ::Derive functions in the visitors #721
Assignees
Milestone
Comments
vgvassilev
added a commit
that referenced
this issue
Jun 11, 2024
The intent of this patch is to centralize the information about the diff request in one place. This will help upcoming patches to reduce the state of the visitors and refactor some of the implementation in a common place. That will unblock work on #721.
vgvassilev
added a commit
that referenced
this issue
Jun 11, 2024
The intent of this patch is to centralize the information about the diff request in one place. This will help upcoming patches to reduce the state of the visitors and refactor some of the implementation in a common place. That will unblock work on #721.
vgvassilev
added a commit
that referenced
this issue
Jun 11, 2024
The intent of this patch is to centralize the information about the diff request in one place. This will help upcoming patches to reduce the state of the visitors and refactor some of the implementation in a common place. That will unblock work on #721.
vgvassilev
added a commit
that referenced
this issue
Jul 7, 2024
…y it. The idea of this change is to separate the analysis steps from the building step. That would help us detect unsupported cases and provide useful diagnostics without crashing. The centralization will help with enabling the future activity analysis in other modes, too. Partially addresses #721.
vgvassilev
added a commit
that referenced
this issue
Jul 11, 2024
…y it. The idea of this change is to separate the analysis steps from the building step. That would help us detect unsupported cases and provide useful diagnostics without crashing. The centralization will help with enabling the future activity analysis in other modes, too. Partially addresses #721.
vgvassilev
added a commit
that referenced
this issue
Jul 18, 2024
…y it. The idea of this change is to separate the analysis steps from the building step. That would help us detect unsupported cases and provide useful diagnostics without crashing. The centralization will help with enabling the future activity analysis in other modes, too. Partially addresses #721.
vgvassilev
added a commit
that referenced
this issue
Jul 18, 2024
…y it. The idea of this change is to separate the analysis steps from the building step. That would help us detect unsupported cases and provide useful diagnostics without crashing. The centralization will help with enabling the future activity analysis in other modes, too. Partially addresses #721.
PetroZarytskyi
added a commit
to PetroZarytskyi/clad
that referenced
this issue
Oct 5, 2024
vgvassilev
pushed a commit
to PetroZarytskyi/clad
that referenced
this issue
Oct 5, 2024
vgvassilev
pushed a commit
to PetroZarytskyi/clad
that referenced
this issue
Oct 6, 2024
vgvassilev
pushed a commit
that referenced
this issue
Oct 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
BaseForwardModeVisitor, ReverseModeForwPassVisitor, HessianModeVisitor and JacobianModeVisitor have practically a common method
Derivewhich duplicates a lot of code. We should move the common code into a utility class that's shared between the visitors.The text was updated successfully, but these errors were encountered: