Remove the use_enzyme state from reverse mode visitor. NFC #946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
clang-tidy review says "All clean, LGTM! 👍" |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #946 +/- ##
==========================================
- Coverage 93.80% 93.80% -0.01%
==========================================
Files 55 55
Lines 7828 7826 -2
==========================================
- Hits 7343 7341 -2
Misses 485 485
|
vaithak
approved these changes
Jun 18, 2024
vgvassilev
force-pushed
the
remove-use_enzyme
branch
from
6a069f2
to
22c027e
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -63,7 +63,7 @@ namespace clad { | |||
| std::vector<Stmts> m_LoopBlock; | |||
| unsigned outputArrayCursor = 0; | |||
| unsigned numParams = 0; | |||
| bool use_enzyme = false; | |||
| bool isVectorValued = false; | |||
There was a problem hiding this comment.
warning: invalid case style for protected member 'isVectorValued' [readability-identifier-naming]
Suggested change
| bool isVectorValued = false; | |
| bool m_isVectorValued = false; |
| @@ -63,7 +63,7 @@ | |||
| std::vector<Stmts> m_LoopBlock; | |||
| unsigned outputArrayCursor = 0; | |||
| unsigned numParams = 0; | |||
| bool use_enzyme = false; | |||
| bool isVectorValued = false; | |||
There was a problem hiding this comment.
warning: member variable 'isVectorValued' has protected visibility [cppcoreguidelines-non-private-member-variables-in-classes]
bool isVectorValued = false;
^Partially addresses #721.
vgvassilev
force-pushed
the
remove-use_enzyme
branch
from
22c027e
to
21939fb
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #721.