Migrate JFace Viewer tests to JUnit 4 #1222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 899 files + 899 899 suites +899 1h 31m 4s ⏱️ + 1h 31m 4s For more details on these failures, see this check. Results for commit 1bba52c. ± Comparison against base commit 5f47dac. ♻️ This comment has been updated with latest results. |
* Migrates the tests in org.eclipse.jface.tests.viewer to JUnit 4 * Replaces some test method precondition checks with assume calls * Replaces test name access with TestName rule
HeikoKlare
force-pushed
the
jface-viewer-migrate-junit4
branch
from
610daf7
to
1bba52c
Compare
fedejeanne
reviewed
Oct 17, 2023
| @@ -275,6 +292,7 @@ public void testGetBackground() { | |||
| // getDecoratingStyledLabelProvider().getBackground(ti)); | |||
| } | |||
|
|
|||
| @Test | |||
| public void testGetFont() { | |||
There was a problem hiding this comment.
Could be removed in another PR
fedejeanne
reviewed
Oct 17, 2023
| @@ -229,6 +247,7 @@ public void testRefreshWithDuplicateChild() { | |||
| * expanded, B is not - A gets deleted - B gets expanded because it reused A's | |||
| * item | |||
| */ | |||
| @Test | |||
| public void testRefreshWithReusedItems() { | |||
There was a problem hiding this comment.
Could be removed in another PR
fedejeanne
approved these changes
Oct 17, 2023
| @@ -272,6 +293,7 @@ public void testSetExpandedWithCycle() { | |||
| * Test for Bug 41710 - assertion that an object may not be added to a given | |||
| * TreeItem more than once. | |||
| */ | |||
| @Test | |||
| public void testSetDuplicateChild() { | |||
| // Widget root = fViewer.testFindItem(fRootElement); | |||
| // assertNotNull(root); | |||
fedejeanne
approved these changes
Oct 17, 2023
|
Error failure documented here #1005 |
|
Thanks @HeikoKlare |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
org.eclipse.jface.tests.viewerto JUnit 4TestNamerule